Update C++ core and assert the service set a bucket ping reports

[avsej]

Motivation

test_bucket_ping asserts that a bucket ping reports key/value and
nothing else. CXXCBC-845, which added wait_until_ready, also made a
bucket-scoped ping cover the cluster-level HTTP services, so the
assertion describes a contract the core no longer has and every mock
job fails on it.

The reported set was not stable either. The ping collector completed as
soon as the number of in-flight pings reached zero, which it can do
while the fan-out is still being dispatched, and the cluster-level
services are pinged from the node list in the configuration the session
manager holds. A ping issued before that configuration arrives
registers no reporter for those services and completes on the key/value
reporters alone; one issued afterwards reports every service the
topology advertises.

Modifications

The core moves to efc5278,
which holds a dispatch scope open across the whole ping fan-out
(CXXCBC-1022) so the collector cannot complete while endpoints are
still being handed reporters.

The default bucket ping is then asserted to report key/value and to
cover the same services as a cluster ping, which states the current
contract without naming the services a particular cluster happens to
deploy. The single-service case takes its service list from the
cluster's own ping rather than a fixed one, so it exercises the
bucket-scoped filtering for every service the cluster under test
deploys, and requires key/value among them so that an empty list cannot
satisfy it.

Results

A bucket ping reports every service the topology advertises, regardless
of when it is issued relative to the configuration arriving. The
comparison against a cluster ping distinguishes the fixed core from the
broken one: against a core without CXXCBC-1022 a bucket ping that runs
before the configuration reaches the session manager reports key/value
alone and the comparison fails.

[Copilot]

🟢 Approval recommended

The assertions accurately cover both timing-dependent default behavior and deterministic service filtering.

Pull request overview

Updates diagnostics tests for bucket pings that may include cluster-level services.

Changes:

• Requires default bucket pings to include key/value.
• Adds deterministic coverage for key/value-only bucket pings.

File summaries

File	Description
test/diagnostics_test.rb	Adjusts bucket ping assertions and adds a scoped ping test.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.