Skip to content

Update C++ core and assert the service set a bucket ping reports #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsej merged 2 commits into from
Sep 9, 2026
Merged

Update C++ core and assert the service set a bucket ping reports #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90904c4
Update C++ core to efc5278
avsej Sep 9, 2026
19874b3
Test: assert the service set a bucket ping reports
avsej Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/couchbase
Open in desktop
Submodule couchbase updated from b08e9f to efc527
18 changes: 16 additions & 2 deletions test/diagnostics_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,22 @@ def test_cluster_ping_single_service
def test_bucket_ping
res = @bucket.ping

assert_equal 1, res.services.size
assert_equal :kv, res.services.keys[0]
assert_includes res.services.keys, :kv
# Catches a ping collector that completes before the whole fan-out has been
# dispatched (CXXCBC-1022). Comparing against a cluster ping keeps this
# independent of the topology under test.
assert_equal @cluster.ping.services.keys.sort, res.services.keys.sort
end

def test_bucket_ping_single_service
service_types = @cluster.ping.services.keys

assert_includes service_types, :kv
service_types.each do |service_type|
res = @bucket.ping(Options::Ping.new(service_types: [service_type]))

assert_equal [service_type], res.services.keys
end
end
end
end
Loading