Normalize notebook cell source before wrapping jobs - #2143
Conversation
|
Thanks for the fix, @Hashim1999164 — this is a real bug and the change looks good (normalizing Before we can merge, external contributions to this repo need a signed Contributor License Agreement (CLA). It's a one-time agreement confirming you have the right to submit this contribution and granting Databricks permission to distribute it under the project's license — it's about licensing, not your code, and once signed it also covers any future contributions from you. Two quick things so we can get it to you:
Once you confirm, I'll have our legal team send over the CLA. After it's signed and returned, we'll get this merged. Thanks again! |
|
Yes, I am ready to sign the CLA. I am contributing as an individual, not on behalf of a company. Name: Hashim Khan Please send the CLA to that email. I will sign it when it arrives. |
|
@rugpanov Just checking in on the CLA email. I am still ready to sign as an individual. Please send it to sardarhashim30@gmail.com whenever it is ready. |
|
Hi @Hashim1999164 , our legal team has sent you the CLA. |
|
@rugpanov I signed the CLA in DocuSign just now and returned it. Please let me know if legal still needs anything else. |
36fa587 to
af436a5
Compare
af436a5 to
f897790
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Thanks so much for this fix, @Hashim1999164 🙏 Nice catch and a clean, well-scoped fix — normalizing I've rebased it onto the latest |
Release **v2.16.0** of the Databricks VS Code extension. Tracking: DECO-28403 ## packages/databricks-vscode - Add a manual mode to opt out of automated Python environment (uv) setup (#2158) - Offer a one-click "Install uv" action when uv is missing (#2162) - Prompt re-login on setup-local session expiry instead of a hard error (#2163) - Normalize notebook cell source before wrapping jobs, fixing "Run as Databricks Job" when a cell's source is a JSON string (#2143) — reported in #2142 - Update Databricks CLI to v1.14.1 (#2160) — see the [CLI release notes](https://github.com/databricks/cli/releases) for changes _Changelog curated: internal refactor (#2148) and CI/test-only changes (#2165, #2141) omitted; auto-close issue refs stripped._ --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: @rugpanov <gripanov@gmail.com>
Changes
Run as Databricks Job crashed when an ipynb cell source was a JSON string. Nbformat allows a string or a list. The wrapper now normalizes source to lines before calling flatMap.
Fixes #2142
Tests
Added a unit test with a string cell source next to the existing list source wrap test.