ci: stabilize optional backend workflows - #5945
Conversation
f2ce3aa to
af99fc5
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workflows pin uv setup, limit download concurrency, allow Paddle matrix failures, and disable Paddle in CUDA CI. Backend validation now accepts missing Paddle when the CI override is enabled. ChangesCI workflow updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/build_wheel.yml (1)
59-61: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin
astral-sh/setup-uvto an immutable commit.
version: "0.12.0"pins the uv binary, not the action implementation. Replace@v9with the commit SHA for the intended release. The v9.0.0 documentation identifiesc771a70e6277c0a99b617c7a806ffedaca235ff9as its release commit. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build_wheel.yml around lines 59 - 61, Pin the astral-sh/setup-uv action to the immutable v9.0.0 release commit c771a70e6277c0a99b617c7a806ffedaca235ff9 instead of the mutable `@v9` reference, while preserving the existing version input for the uv binary.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build_wheel.yml:
- Around line 59-61: Update the setup-uv step using astral-sh/setup-uv@v9 to
explicitly set enable-cache to false, disabling implicit caching for the
untrusted build job while preserving the existing uv version configuration.
In @.github/workflows/test_cuda.yml:
- Around line 16-19: Add a workflow-level permissions block in the CUDA CI
workflow with only contents: read, ensuring it does not inherit broader token
scopes while leaving the existing DP_ENABLE_PADDLE environment setting
unchanged.
---
Nitpick comments:
In @.github/workflows/build_wheel.yml:
- Around line 59-61: Pin the astral-sh/setup-uv action to the immutable v9.0.0
release commit c771a70e6277c0a99b617c7a806ffedaca235ff9 instead of the mutable
`@v9` reference, while preserving the existing version input for the uv binary.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9011e8d8-6781-4e7d-8c70-9b8ce6b09ba6
📒 Files selected for processing (3)
.github/workflows/build_wheel.yml.github/workflows/test_cc.yml.github/workflows/test_cuda.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5945 +/- ##
==========================================
- Coverage 79.41% 79.21% -0.20%
==========================================
Files 1071 1072 +1
Lines 124844 125041 +197
Branches 4531 4540 +9
==========================================
- Hits 99144 99056 -88
- Misses 24079 24360 +281
- Partials 1621 1625 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow Paddle-only C++ matrix entries to fail without cancelling other jobs, temporarily disable Paddle in CUDA CI, and reduce macOS wheel dependency download pressure with setup-uv. Coding-Agent: Codex Codex-Version: codex-cli 0.144.6 Model: gpt-5.6-sol Reasoning-Effort: xhigh
af99fc5 to
a3d601c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
source/tests/consistent/common.py:76
- The ImportError message no longer matches the CI gate condition: the logic requires TensorFlow and PyTorch to be available, and Paddle only if it’s installed or DP_CI_ALLOW_MISSING_PADDLE=1. With the new allow-missing switch, the current message (“TensorFlow, PyTorch or Paddle…”) is misleading during CI failures and makes debugging harder.
and not (
INSTALLED_TF and INSTALLED_PT and (INSTALLED_PD or CI_ALLOW_MISSING_PADDLE)
)
):
raise ImportError("TensorFlow, PyTorch or Paddle should be tested in the CI")
f573ca0
Summary
Failure analysis
The referenced macOS ARM job successfully built and repaired the wheel. It failed while installing wheel test dependencies because downloading lmdb raised No buffer space available (os error 55). The macOS wheel remains blocking so release runs cannot silently publish without that artifact; limiting uv download concurrency targets the observed runner resource failure.
Validation
Coding agent: Codex
Codex version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning effort: xhigh
Summary by CodeRabbit
Chores
Tests