fix utils tests and examples to accommodate get_properties changes, add utils for creation of schedules#51
Closed
jackraymond wants to merge 49 commits into
Closed
Conversation
jackraymond
force-pushed
the
feature/schedule-helper-functions
branch
from
40e6206 to
78c22f7
Compare
jackraymond
changed the title
thisac
reviewed
Jun 26, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 94.29% 91.32% -2.97%
==========================================
Files 15 15
Lines 1139 1360 +221
==========================================
+ Hits 1074 1242 +168
- Misses 65 118 +53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…erval=polarized_preparation_interval
… depolarized preparation
jackraymond
force-pushed
the
feature/schedule-helper-functions
branch
from
229dc37 to
3b9d2f1
Compare
thisac
reviewed
Jul 8, 2026
Comment on lines
+881
to
+909
| pattern of PWL construction doesn't change. | ||
| pattern of PWL construction doesnt change. |
|
|
||
| import networkx as nx | ||
|
|
||
| from dwave_networkx import zephyr_coordinates |
Contributor
There was a problem hiding this comment.
These should be changed to dwave-graphs.
Comment on lines
+88
to
+89
| :func:`dwave_networkx.zephyr_graph` and | ||
| :func:`dwave_networkx.zephyr_coordinates`. |
Contributor
There was a problem hiding this comment.
These should also be changed to dwave-graph.
Comment on lines
+280
to
+281
| raise ValueError("delay must be non-negative.") | ||
| completion_time = max(pwl[-1][0] for pwl in anneal_schedules) |
Contributor
There was a problem hiding this comment.
Suggested change
| raise ValueError("delay must be non-negative.") | |
| completion_time = max(pwl[-1][0] for pwl in anneal_schedules) | |
| raise ValueError("delay must be non-negative.") | |
| completion_time = max(pwl[-1][0] for pwl in anneal_schedules) |
| and min time steps. It checks terminal values of the polarizing schedules | ||
| match those of anneal_schedules, and all schedules begin at time 0. | ||
|
|
||
| It does not exhaustively check all requirements. See Documentation. |
Comment on lines
+301
to
+307
| def verify_schedules( | ||
| exp_feature_info: list[dict, list[LineFeatureInfo]], | ||
| x_anneal_schedules: AnnealSchedules | None = None, | ||
| x_polarizing_schedule: AnnealSchedule | None = None, | ||
| check_rounding: bool = True, | ||
| term_time: float | None = None, | ||
| ): |
Contributor
There was a problem hiding this comment.
Bumping this also. Still think that this can be simplified by splitting it up.
Comment on lines
+881
to
+883
| for line in all_lines: | ||
| if anneal_schedules[line][0][0] != 0: | ||
| anneal_schedules[line] = [[0.0, 0.0]] + anneal_schedules[line] |
Contributor
There was a problem hiding this comment.
Since all_lines is a set, and anneal_schedules is created by iterating through the set, it's not certain that anneal_schedules[line] refers to the same one that was created earlier. Sets aren't ordered, so instead you could either use a dictionary for anneal_schedules or make all_lines a sequence before creating anneal_schedules.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper functions for the creation of target-detector-source schedules is added.