Fix/api change compatibility#60
Open
jackraymond wants to merge 10 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 15 15
Lines 1141 1141
=======================================
Hits 1076 1076
Misses 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thisac
approved these changes
Jul 9, 2026
thisac
left a comment
thisac
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I noticed that there's some coverage missing for the mca tests, but this might be better addressed separately (specifically exceptions aren't being tested + some edge cases).
| Args: | ||
| delays: time of measurement | ||
| A: frequency | ||
| decay_time: exponential envelope time scale |
Contributor
There was a problem hiding this comment.
Need to update this as well.
randomir
reviewed
Jul 9, 2026
Comment on lines
+4
to
+5
| Update examples, tests and utils to accommodate modified get_properties | ||
| return format. |
Member
There was a problem hiding this comment.
Can you also please update the get_properties() (return type, docs) to reflect the new format returned by the server?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples and tests are updated to fix breakages caused by changes to the get_properties return format.
Defaults are modified to accommodate the change from Advantage2_research1 to Advantage2_research2.
This pull request contains a subset of changes in #51.