fix(home-assistant): allow partial forecast entity configuration - #56
Open
Herbertmt978 wants to merge 3 commits into
Open
fix(home-assistant): allow partial forecast entity configuration#56Herbertmt978 wants to merge 3 commits into
Herbertmt978 wants to merge 3 commits into
Conversation
Herbertmt978
marked this pull request as ready for review
July 27, 2026 22:17
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe8bb7efa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This is a small backend-focused improvement related to #31.
Why
The Home Assistant forecast schema presents its entity IDs as optional, and the provider already skips missing entities while returning the data that is available. Two builder guards still required the current-hour power and energy entities, so otherwise valid partial configurations failed during adapter initialization.
The builder now accepts partial configurations while still requiring at least one usable forecast entity.
Scope
This intentionally stays small and backend-focused. It does not implement the broader form validation or UI status/error handling discussed in #31, and it is not intended to close #31.
Refs #31
Validation
python -m pytest tests/unit/adapters/domain/forecast/test_home_assistant_api.py -q— 2 passed.python -m pytest tests/unit -q— 619 passed.python -m ruff format --check edge_mining tests— 394 files already formatted.python -m ruff check edge_mining— passed.python -m pytest tests -q— 665 passed, with 5 Windows-only persistence teardown errors. Each error wasPermissionError: [WinError 32]while deleting a temporary SQLite database that was still open; the affected integration cleanup paths are outside this change.