-
Notifications
You must be signed in to change notification settings - Fork 3
fix(home-assistant): allow partial forecast entity configuration #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Herbertmt978
wants to merge
3
commits into
edge-mining:main
Choose a base branch
from
Herbertmt978:Herb/allow-partial-ha-forecast-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
core/tests/unit/adapters/domain/forecast/test_home_assistant_api.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| from unittest.mock import AsyncMock, MagicMock | ||
|
|
||
| import pytest | ||
|
|
||
| from edge_mining.adapters.domain.forecast.providers.home_assistant_api import ( | ||
| HomeAssistantForecastProviderFactory, | ||
| ) | ||
| from edge_mining.domain.forecast.exceptions import ForecastError | ||
| from edge_mining.shared.adapter_configs.forecast import ForecastProviderHomeAssistantConfig | ||
| from edge_mining.shared.external_services.common import ExternalServiceAdapter | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_factory_accepts_partial_entity_configuration(): | ||
| home_assistant = MagicMock() | ||
| home_assistant.external_service_type = ExternalServiceAdapter.HOME_ASSISTANT_API | ||
| home_assistant.get_entity_state = AsyncMock(return_value=("1.5", {})) | ||
| home_assistant.parse_energy.return_value = 1.5 | ||
| config = ForecastProviderHomeAssistantConfig( | ||
| entity_forecast_energy_today="sensor.solar_forecast_today", | ||
| ) | ||
|
|
||
| provider = HomeAssistantForecastProviderFactory().create( | ||
| config=config, | ||
| logger=None, | ||
| external_service=home_assistant, | ||
| ) | ||
|
|
||
| assert provider.entity_forecast_energy_today == "sensor.solar_forecast_today" | ||
| assert provider.entity_forecast_power_actual_h is None | ||
| assert provider.entity_forecast_energy_actual_h is None | ||
|
|
||
| forecast = await provider.get_forecast() | ||
|
|
||
| assert len(forecast.intervals) == 1 | ||
| home_assistant.get_entity_state.assert_awaited_once_with("sensor.solar_forecast_today") | ||
|
|
||
|
|
||
| def test_factory_rejects_empty_entity_configuration(): | ||
| home_assistant = MagicMock() | ||
| home_assistant.external_service_type = ExternalServiceAdapter.HOME_ASSISTANT_API | ||
|
|
||
| with pytest.raises(ForecastError, match="At least one Home Assistant forecast entity is required"): | ||
| HomeAssistantForecastProviderFactory().create( | ||
| config=ForecastProviderHomeAssistantConfig(), | ||
| logger=None, | ||
| external_service=home_assistant, | ||
| ) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.