[steps] Unify the default gating of steps with no if: across steps, composite scopes, and hooks - #4061
Open
sswrk wants to merge 2 commits into
Conversation
This was referenced Jul 23, 2026
Member
Author
This was referenced Jul 23, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files #4061 +/- ##
===========================================================================================================
Coverage ? 62.22%
===========================================================================================================
Files ? 995
Lines ? 44754
Branches ? 9412
===========================================================================================================
Hits ? 27845
Misses ? 15462
Partials ? 1447 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
2 times, most recently
from
July 23, 2026 17:06
88b25ed to
afe2ad9
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
2 times, most recently
from
July 24, 2026 11:43
2e31826 to
f859121
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 24, 2026 11:43
afe2ad9 to
de031b5
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 24, 2026 11:49
f859121 to
5a62c3b
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 24, 2026 11:49
de031b5 to
73ece96
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 24, 2026 12:31
5a62c3b to
62b5bae
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 24, 2026 12:31
73ece96 to
be7ec02
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 24, 2026 13:02
62b5bae to
496e454
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
2 times, most recently
from
July 24, 2026 14:12
0236cea to
f14d4f6
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
2 times, most recently
from
July 24, 2026 14:39
d04c89f to
b805c1f
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 24, 2026 14:40
f14d4f6 to
fb5d85f
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 24, 2026 14:58
b805c1f to
5113e42
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 24, 2026 14:59
fb5d85f to
0a629b7
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 24, 2026 15:16
5113e42 to
4c6e667
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 24, 2026 15:16
0a629b7 to
32f79bd
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
2 times, most recently
from
July 27, 2026 10:10
079d504 to
f20c574
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 27, 2026 10:10
09e0c46 to
6983371
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 27, 2026 11:11
f20c574 to
79cbcd4
Compare
if: across steps, composite scopes, and hooks
sswrk
marked this pull request as ready for review
July 27, 2026 13:08
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 27, 2026 14:59
79cbcd4 to
ccd5926
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 27, 2026 14:59
6983371 to
18d77aa
Compare
This was referenced Jul 27, 2026
sjchmiela
approved these changes
Jul 28, 2026
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 28, 2026 12:58
18d77aa to
9551a61
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
2 times, most recently
from
July 28, 2026 15:30
bfe042d to
c692851
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
from
July 28, 2026 15:30
9551a61 to
8364018
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 29, 2026 09:01
c692851 to
f9f51cc
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-eas-cli-validate-custom-actions-in-workflow-files
branch
3 times, most recently
from
July 29, 2026 09:26
2f8a515 to
ab74d1e
Compare
sswrk
force-pushed
the
szymonswierk/eng-22387-steps-unify-no-if-gating-policy
branch
from
July 29, 2026 09:26
f9f51cc to
e693624
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
For a step with no
if:, whether the step should run was decided in 3 separate places:BuildStep.shouldExecuteStep, the composite function scope (same rule), and the hook executor (its own rule). That bypass means composite scopes never see hook defaults, which is a blocker for adding support for composite functions in hooks.How
A single gate now decides whether any step runs, taking a single input: a bool telling whether a step with no
if:should run. Composite functions called from hooks therefore inherit the hook's rule. Steps with an explicitif:are unaffected.Behavior-preserving refactor.
Test Plan
shouldExecuteStep/isActive, and hook sibling skip/continue cases for the before/after defaults.