[eas-cli] Validate legacy command/path local functions referenced from workflows - #4098
Draft
sswrk wants to merge 1 commit into
Conversation
This was referenced Jul 27, 2026
Member
Author
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
branch
from
July 27, 2026 15:02
76ac6a7 to
c1e1802
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-build-tools-load-legacy-functions
branch
from
July 27, 2026 15:02
34f9038 to
6ce77e0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## szymonswierk/eng-25402-build-tools-load-legacy-functions #4098 +/- ##
============================================================================================
+ Coverage 62.33% 62.34% +0.02%
============================================================================================
Files 996 996
Lines 44881 44894 +13
Branches 9443 9446 +3
============================================================================================
+ Hits 27973 27986 +13
Misses 15462 15462
Partials 1446 1446 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sswrk
force-pushed
the
szymonswierk/eng-25402-build-tools-load-legacy-functions
branch
from
July 28, 2026 09:04
6ce77e0 to
c468e34
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
branch
2 times, most recently
from
July 28, 2026 12:58
71cf625 to
a0450ff
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-build-tools-load-legacy-functions
branch
2 times, most recently
from
July 28, 2026 13:11
d2e8524 to
5554d33
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
branch
from
July 28, 2026 13:11
a0450ff to
c3d3b6d
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-build-tools-load-legacy-functions
branch
from
July 28, 2026 15:30
5554d33 to
76e0f68
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
branch
2 times, most recently
from
July 29, 2026 09:01
7b0c93a to
b053726
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-build-tools-load-legacy-functions
branch
from
July 29, 2026 09:29
2da65a9 to
d1cc5f1
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
branch
from
July 29, 2026 09:30
b053726 to
b91cd16
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
branch
from
July 29, 2026 13:40
b91cd16 to
e34b99c
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-build-tools-load-legacy-functions
branch
from
July 29, 2026 13:40
d1cc5f1 to
548b648
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
eas workflow:validateandeas workflow:createcheck referenced local functions before anything is submitted, so mistakes surface on the developer's machine instead of failing the build later. Completes the stack that lets custom build functions from.eas/buildconfigs move into.eas/functions(#4095, #4096, #4097).How
Validates
function.ymlfiles with the widenedLocalFunctionConfigZ, so both shapes are accepted and a file mixing them is rejected with a readable error. For apathfunction, checks that the module directory and itspackage.jsonexist locally, resolving the path with the same shared helper the build runner uses and naming both the literalpath:value and the resolved location in the error.Test Plan
cd packages/eas-cli && yarn test src/commandUtils/workflow/__tests__/compositeFunctions-test.tsValidation tests: a
commandfunction and apathfunction with an existing module pass; a missing module directory, a module withoutpackage.jsonand a config mixing both shapes each fail with a readable error.Also smoke-tested end to end against a scratch project:
validateWorkflowLocalCompositeFunctionsAsyncaccepted workflows calling acommandfunction and apathfunction, and rejected apathfunction whose module directory was missing.