fix(theme-neutral): apply component contrast treatments - #5690
Closed
rubyycheung wants to merge 3 commits into
Closed
fix(theme-neutral): apply component contrast treatments#5690rubyycheung wants to merge 3 commits into
rubyycheung wants to merge 3 commits into
Conversation
rubyycheung
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
August 30, 2026 08:16
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 30, 2026
rubyycheung
force-pushed
the
codex/neutral-theme-component-contrast
branch
from
August 30, 2026 08:25
49ea878 to
5b63822
Compare
rubyycheung
force-pushed
the
codex/neutral-theme-palette-contrast
branch
from
August 30, 2026 08:56
71560b0 to
b19fc7a
Compare
rubyycheung
force-pushed
the
codex/neutral-theme-component-contrast
branch
from
August 30, 2026 09:00
5b63822 to
1fdac76
Compare
xinzi-bot
reviewed
Aug 30, 2026
xinzi-bot
left a comment
There was a problem hiding this comment.
Thanks, this is close. The SelectableCard ring override is too broad: putting it on selectable-card.base means custom Card variants inherit the neutral ring instead of the documented accent fallback, and saturated custom fills drop to ~1.3:1. Could we scope that neutral ring to the built-in variants that need it, and add a custom-variant guard?
[Automated review]
rubyycheung
marked this pull request as draft
August 31, 2026 01:11
Contributor
Author
|
Superseded by #5752, which rebuilds the Neutral theme color work with a cleaner scope. Closing this to avoid reviewing conflicting color/component approaches. |
github-actions
Bot
deleted the
codex/neutral-theme-component-contrast
branch
September 1, 2026 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #5628 now contains only the palette definition and semantic/categorical token remapping. This stacked PR isolates the component-specific decisions so they can be reviewed visually and technically on their own.
Stack
#5627 → #5668 → #5628 → this PR → #5649 → #5667
Verification
@rubyycheung