Skip to content

fix(theme-neutral): apply component contrast treatments - #5690

Closed
rubyycheung wants to merge 3 commits into
codex/neutral-theme-palette-contrastfrom
codex/neutral-theme-component-contrast
Closed

fix(theme-neutral): apply component contrast treatments#5690
rubyycheung wants to merge 3 commits into
codex/neutral-theme-palette-contrastfrom
codex/neutral-theme-component-contrast

Conversation

@rubyycheung

Copy link
Copy Markdown
Contributor

Summary

  • Apply the remapped Neutral palette to component-specific Button, Badge, status indicator, Token, Banner, and ProgressBar treatments.
  • Add an explicit SelectableCard selection-ring theme hook without changing card backgrounds.
  • Remove redundant radius overrides that match Core defaults.
  • Keep the ProgressBar endpoint unchanged and remove the invalid no-op endpoint theme target.
  • Add focused component-pair contrast coverage.

Why

PR #5628 now contains only the palette definition and semantic/categorical token remapping. This stacked PR isolates the component-specific decisions so they can be reviewed visually and technically on their own.

Stack

#5627#5668#5628 → this PR → #5649#5667

Verification

  • 56 focused tests pass, with 2 existing todos.
  • Neutral theme build passes with no unknown component-target warning.
  • Repository checks and source/CLI template parity pass.

@rubyycheung

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 30, 2026 9:03am

Request Review

@xinzi-bot xinzi-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is close. The SelectableCard ring override is too broad: putting it on selectable-card.base means custom Card variants inherit the neutral ring instead of the documented accent fallback, and saturated custom fills drop to ~1.3:1. Could we scope that neutral ring to the built-in variants that need it, and add a custom-variant guard?

[Automated review]

@rubyycheung
rubyycheung marked this pull request as draft August 31, 2026 01:11
@github-actions
github-actions Bot deleted the branch codex/neutral-theme-palette-contrast August 31, 2026 06:28
@rubyycheung

Copy link
Copy Markdown
Contributor Author

Superseded by #5752, which rebuilds the Neutral theme color work with a cleaner scope. Closing this to avoid reviewing conflicting color/component approaches.

@github-actions
github-actions Bot deleted the codex/neutral-theme-component-contrast branch September 1, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants