fix(theme-neutral): remap colors to the approved palette - #5628
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
xinzi-bot
left a comment
There was a problem hiding this comment.
Automated review found one visual regression: the Neutral dark ProgressBar track drops from 2.20:1 to 1.54:1 against body and 1.94:1 to 1.35:1 against surface, while the parent-visibility test remains todo. Preserving current track visibility would avoid the regression.
[Automated review]
|
Thanks for flagging the lower track-to-parent ratios. Those ratios are useful diagnostic data, but they do not determine conformance by themselves. WCAG 1.4.11 applies to the graphical parts required to understand the component, measured against their adjacent colors. For ProgressBar, that depends on its presentation:
The endpoint identifies the total extent of the standalone bar, so the entire track does not additionally need 3:1 against the page or card surface. Requiring that relationship would make every track visually prominent without adding information. The remaining |
71560b0 to
b19fc7a
Compare
xinzi-bot
left a comment
There was a problem hiding this comment.
Re-reviewed exact head: the prior ProgressBar track regression is resolved, palette metadata stays opt-in, and changed-file TODO coverage is clean. @imdreamrunner, this looks ready for your approval.
[Automated review]
Summary
Why
This gives people and agents one exact, versioned source of color truth instead of independently inventing nearby hex values. Palette metadata remains opt-in, while the default runtime theme stays lean.
Component-specific behavior and contrast treatments are intentionally excluded and reviewed separately in #5690.
WCAG scope
This PR establishes contrast-aware color mappings. Component-specific pairings and exceptions are validated in #5690.
Stack
#5627 → #5668 → this PR → #5690 → #5649 → #5667
Verification
@rubyycheung