Use semantic icons for status indicators - #5671
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
humbertovirtudes
left a comment
There was a problem hiding this comment.
LGTM updates make sense!
|
@ernestt can you check the CI / test failures? |
|
/accept-visual 33293627054/1 Semantic status icons intentionally replace generic marks with the approved theme-aware status glyphs. |
|
Visual acceptance refused: that evidence is not from the latest completed CI attempt for this head. |
|
/accept-visual 33293627054/1 Semantic status icons intentionally replace generic marks with the approved theme-aware status glyphs. |
|
Visual acceptance could not be recorded. See this workflow run for the rejected invariant or infrastructure error. |
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsChat (@astryxdesign/core) · View in Storybook
Table (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual Regression148 of 1316 shot(s) changed. View the report To accept these exact frames: A change here is a question, not a failure: check whether the after is the
and 128 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
|
/accept-visual 33293627054/3 Brings consistency to icon usage and theme-ability. |
|
Visual changes accepted for |









Summary
success,warning, anderrortable-row statuses through the active theme's semantic icon registry by defaultChatToolCallsthrough thesuccessanderrorsemantic iconsVisual comparison
The same Neutral-theme Storybook fixture, at the same viewport, before and after the change.
Before
After
Test plan
pnpm exec vitest run packages/core/src/Chat/ChatToolCalls.test.tsx packages/core/src/Table/plugins/rowStatus/useTableRowStatus.test.tsx(25 passed)pnpm buildpnpm -F @astryxdesign/storybook typecheckpnpm -F @astryxdesign/core lint(passes with existing warnings)check:sync, package boundaries, changesets, demo media, executable bits, CLI structure, client directives, portable scripts, i18n, CLDR, fixtures)