Skip to content

Use semantic icons for status indicators - #5671

Merged
rubyycheung merged 2 commits into
mainfrom
ernestt/semantic-status-icons
Aug 31, 2026
Merged

Use semantic icons for status indicators#5671
rubyycheung merged 2 commits into
mainfrom
ernestt/semantic-status-icons

Conversation

@ernestt

@ernestt ernestt commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve success, warning, and error table-row statuses through the active theme's semantic icon registry by default
  • route completed and failed ChatToolCalls through the success and error semantic icons
  • retain explicit icon overrides and dot fallback behavior for palette/raw table-row colors
  • update the table-row example and component docs

Visual comparison

The same Neutral-theme Storybook fixture, at the same viewport, before and after the change.

Before

Before: table rows use dots and tool calls use generic check/close marks

After

After: table rows and tool calls use the theme's semantic status icons

Test plan

  • pnpm exec vitest run packages/core/src/Chat/ChatToolCalls.test.tsx packages/core/src/Table/plugins/rowStatus/useTableRowStatus.test.tsx (25 passed)
  • pnpm build
  • pnpm -F @astryxdesign/storybook typecheck
  • pnpm -F @astryxdesign/core lint (passes with existing warnings)
  • pre-commit repository checks (check:sync, package boundaries, changesets, demo media, executable bits, CLI structure, client directives, portable scripts, i18n, CLDR, fixtures)

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 30, 2026 5:00am

Request Review

@github-actions github-actions Bot added the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Aug 28, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 28, 2026
github-actions Bot added a commit that referenced this pull request Aug 28, 2026
@ernestt
ernestt marked this pull request as ready for review August 28, 2026 22:46
@rubyycheung

Copy link
Copy Markdown
Contributor

Coordination note: the Neutral semantic color changes remain separate in #5628. This PR should stay focused on selecting the theme-aware semantic glyphs; when combined, those glyphs inherit the Neutral success, warning, and error colors from #5628.

@humbertovirtudes humbertovirtudes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM updates make sense!

@github-actions github-actions Bot removed the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Aug 29, 2026
@humbertovirtudes

Copy link
Copy Markdown
Contributor

@ernestt can you check the CI / test failures?

@rubyycheung

Copy link
Copy Markdown
Contributor

/accept-visual 33293627054/1 Semantic status icons intentionally replace generic marks with the approved theme-aware status glyphs.

@github-actions

Copy link
Copy Markdown
Contributor

Visual acceptance refused: that evidence is not from the latest completed CI attempt for this head.

@rubyycheung
rubyycheung enabled auto-merge (squash) August 30, 2026 05:06
github-actions Bot added a commit that referenced this pull request Aug 30, 2026
@rubyycheung

Copy link
Copy Markdown
Contributor

/accept-visual 33293627054/1 Semantic status icons intentionally replace generic marks with the approved theme-aware status glyphs.

@github-actions

Copy link
Copy Markdown
Contributor

Visual acceptance could not be recorded. See this workflow run for the rejected invariant or infrastructure error.

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

Chat (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 5400 -
Complexity N/A Very High (439) -
Table (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1950 -
Complexity N/A Very High (112) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: No accessibility violations detected.

Visual Regression

148 of 1316 shot(s) changed. View the report

To accept these exact frames: /accept-visual 33293627054/3 <reason>

A change here is a question, not a failure: check whether the after is the
picture you intended. If it is, say so in the PR — the release gate's baseline
is updated deliberately, and this check never rewrites it.

component story theme mode pixels
Chat Single Call y2k dark 204
Chat Multiple Calls y2k dark 204
Chat With Nodes y2k dark 204
Chat With Stats y2k dark 204
Chat Running y2k dark 204
Chat Many Calls y2k dark 204
Chat Interactive y2k dark 204
Chat With Errors y2k dark 194
Chat Error With Detail y2k dark 194
Chat All Statuses y2k dark 194
Chat Full AI Chat stone light 118
Chat Single Call stone light 118
Chat Multiple Calls stone light 118
Chat With Nodes stone light 118
Chat With Stats stone light 118
Chat Running stone light 118
Chat Many Calls stone light 118
Chat Interactive stone light 118
Chat Full AI Chat neutral light 111
Chat Full AI Chat butter light 111

and 128 more.

Chat — Single Call — y2k dark
BeforeAfterDiff
Before visual regression frame After visual regression frame Pixel difference frame
Chat — Multiple Calls — y2k dark
BeforeAfterDiff
Before visual regression frame After visual regression frame Pixel difference frame
Chat — With Nodes — y2k dark
BeforeAfterDiff
Before visual regression frame After visual regression frame Pixel difference frame

Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@ernestt

ernestt commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

/accept-visual 33293627054/3 Brings consistency to icon usage and theme-ability.

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@github-actions github-actions Bot added the visual-approved Current visual bundle has an explicit acceptance record label Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Visual changes accepted for 70b2d6adeb5d. A new push invalidates this approval; after merge, the reviewed AFTER frames must reproduce before the baseline is promoted.

@rubyycheung
rubyycheung merged commit 236860c into main Aug 31, 2026
48 checks passed
github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@github-actions
github-actions Bot deleted the ernestt/semantic-status-icons branch September 1, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. visual-approved Current visual bundle has an explicit acceptance record

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants