docs(Table): define row-status contract - #5830
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
force-pushed
the
docs/table-row-status-contract
branch
from
September 1, 2026 17:27
66c7f58 to
4bed73d
Compare
cixzhang
force-pushed
the
docs/table-row-status-contract
branch
from
September 1, 2026 18:46
4bed73d to
a496c2a
Compare
cixzhang
changed the base branch from
main
to
table-plugin-spec-infrastructure
September 1, 2026 18:46
cixzhang
force-pushed
the
table-plugin-spec-infrastructure
branch
from
September 1, 2026 19:10
c645d93 to
9bceb6f
Compare
cixzhang
force-pushed
the
docs/table-row-status-contract
branch
from
September 1, 2026 19:18
a496c2a to
1192259
Compare
cixzhang
force-pushed
the
table-plugin-spec-infrastructure
branch
from
September 1, 2026 19:34
9bceb6f to
08754f1
Compare
cixzhang
force-pushed
the
docs/table-row-status-contract
branch
from
September 1, 2026 20:03
1192259 to
d7a3186
Compare
cixzhang
force-pushed
the
docs/table-row-status-contract
branch
from
September 1, 2026 20:10
d7a3186 to
d8511ed
Compare
cixzhang
changed the base branch from
table-plugin-spec-infrastructure
to
main
September 1, 2026 20:10
cixzhang
marked this pull request as ready for review
September 1, 2026 20:22
Contributor
Author
|
/approve-spec d8511ed |
Contributor
Author
|
/approve-spec 1515367 |
This was referenced Sep 1, 2026
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User impact
People scanning dense tables get consistent non-color glyphs for semantic success, warning, and error. Existing stable consumers keep every
0.5.2custom marker unchanged:colorremains paint-only, an omittediconrenders the dot, and an expliciticonrenders the caller-selected glyph.Infrastructure
Module-contract infrastructure landed on main in #5833. This PR now targets current
maindirectly.Semantic before → after
Before: current canaries overload
TableRowStatus.color:success,warning, anderrorselect both tone and a default icon, while other colors select paint only.After: the exported, declaration-mergeable
TableRowStatusinterface remains byte-for-byte the stable{color, icon?, label}custom-marker contract. A separate exportedTableSemanticRowStatusinterface adds{status, label}. OnlyUseTableRowStatusConfig.getStatusforms their exclusive union by intersecting the custom branch with{status?: never}.Ownership split
component:Tableretains aggregate Table anatomy and the sharedTablePluginprotocol: transform phases, base-before-user ordering, known/custom named ordering, sequential composition, slots, failure isolation, context nesting, and plugin-array identity.module:Table/useTableRowStatusowns its API and exact interfaces, callback boundary, generated column, internalicon | dotvariant, semantic/custom resolution, invalid-input fallback, accessibility, performance/evidence, migration, and theming boundary.Compatibility and release strategy
TableRowStatusannotations, subtypes, extensions, and declaration merging remain valid. Stable0.5.2callers require no edit or codemod.colortostatus.Runtime fallback
For untyped input containing a supported
statusplus forbiddencolorand/oricon, semantic status wins. Custom fields are ignored. Development emits one warning deduplicated for the loaded row-status module instance; production renders the same semantic result without warning.component:Tableandmodule:Table/useTableRowStatusare bothauthority: current, approved bycixzhangon 2026-09-01. Runtime implementation remains explicitly pending.Test plan
pnpm check:knowledge -- --base origin/mainpnpm check:repoNo Changeset: specifications only; no published package behavior changes.