feat(theme): add local tokens and refine Neutral color roles - #5752
feat(theme): add local tokens and refine Neutral color roles#5752rubyycheung wants to merge 11 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4298043 to
99f0dd6
Compare
99f0dd6 to
e90eba0
Compare
6082b6f to
5940255
Compare
5940255 to
4e3970c
Compare
xinzi-bot
left a comment
There was a problem hiding this comment.
The new role-token direction looks good, but Stepper and ProgressBar warning still skip the warning fill mapping, and Stepper’s fallback is only about 1.9:1. This visual PR also needs exact-head light/dark screenshots. Please add both warning overrides and the required visual evidence.
[Automated review]
4e3970c to
9267613
Compare
9267613 to
ceabacf
Compare
cixzhang
left a comment
There was a problem hiding this comment.
Neutral theme updates look good but here's some button updates mixed in that seem unintentional. Could we clean those up? Then the rest is good.
|
Fixed — I removed the Button-specific diff from this PR so #5752 is back to Neutral theme color changes only. Thanks for catching that. |
|
Updated exact head
Focused tests, typechecks, builds, sync checks, package-boundary checks, and the production Storybook build pass. The Vercel preview is also green. This stacked PR does not target Could you please re-review this head? |
|
Closing this mixed PR in favor of focused replacements:
The remaining Neutral color-role adoption will be recreated as a focused PR after its prerequisites (#5668, #5754, and #5844) are available together. That PR will contain only the approved Neutral definitions and mappings, plus exact-head light/dark evidence and the updated colocated Neutral spec. No work is being discarded. The exact current head is preserved at This replacement also carries forward the completed warning mappings and the contrast work, while avoiding a single PR that mixes cross-theme infrastructure, Neutral design adoption, and SegmentedControl geometry. |
|
Final replacement map after removing the remaining inherited stack dependencies:
The focused Neutral status/color adoption will be recreated after #5668, #5844, and #5848 land. The preserved mixed head remains |
|
Updated after rebasing against the newly merged row-status contract #5830:
The Table row-status theming target was not carried forward because #5830 explicitly requires a separate AST-002 proposal before that target or its selector axes can ship. The future focused Neutral color-role adoption should therefore wait for #5668 and #5844, include the approved definitions/mappings and exact-head evidence, and omit row-status mappings unless that separate proposal is approved. |
Summary
localTokenscontract from docs(knowledge): specify theme-local tokens #5801 without changing existingtokensbehavior--astryx-theme-neutral-*namespaceTheme-local token contract
localTokensis optional; themes that omit it retain their previous object shape and behaviorTokenValuecontract: a CSS string or[light, dark]tupleTokenName, token helpers, and Core component source remain unchangedNeutral mappings
Contrast receipts
Filled status label pairs:
The repository Badge contrast guard resolves
localTokensand passes for all Neutral semantic variants. Trusted exact-head screenshots are produced by the visual CI workflow for final Neutral ratification.Validation
pnpm -F @astryxdesign/core typecheckpnpm -F @astryxdesign/core buildpnpm -F @astryxdesign/theme-neutral buildpnpm -F @astryxdesign/cli typecheck:strictpnpm -F @astryxdesign/cli typecheck:authoringpnpm -F @astryxdesign/cli typecheck:template-docspnpm bundle:cli-themespnpm check:syncpnpm check:changesetspnpm check:package-boundariesNotes