Skip to content

fix(theme-neutral): refine SegmentedControl inset - #5846

Closed
rubyycheung wants to merge 1 commit into
codex/table-row-status-theming-targetfrom
codex/neutral-segmented-control-styling
Closed

fix(theme-neutral): refine SegmentedControl inset#5846
rubyycheung wants to merge 1 commit into
codex/table-row-status-theming-targetfrom
codex/neutral-segmented-control-styling

Conversation

@rubyycheung

Copy link
Copy Markdown
Contributor

Summary

  • increase the Neutral SegmentedControl inset to var(--spacing-1)
  • reduce each item height by the matching 8px so the control's outside height remains unchanged
  • remove the selected-item shadow for a flatter Neutral treatment
  • keep the bundled CLI Neutral template synchronized and add a focused contract test

Scope

This is the SegmentedControl styling extracted from #5752. It contains no local-token API work and no status-color changes.

Validation

  • focused Neutral and template tests: 11 passed
  • pnpm -F @astryxdesign/theme-neutral build
  • pnpm -F @astryxdesign/cli typecheck:template-docs
  • pnpm check:sync
  • pnpm check:changesets
  • repository pre-commit validation suite

Before merge

  • capture and approve exact-head light/dark SegmentedControl visuals

Stack

Base: #5754

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 1, 2026 9:10pm UTC

Request Review

@rubyycheung

Copy link
Copy Markdown
Contributor Author

Superseded by #5849, now stacked only on the clean main-based row-status PR #5848.

The SegmentedControl scope, changeset, and validation remain the same; this replacement removes the inherited #5668 palette-stack diff.

@rubyycheung rubyycheung closed this Sep 1, 2026
@github-actions
github-actions Bot deleted the codex/neutral-segmented-control-styling branch September 2, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant