fix(compiler): load UInt64 constants as raw bits#89
Merged
Conversation
load-constant passed the raw UInt64 to il/ldc-i8, and mage's emit fallthrough resolves the Emit overload reflectively from the operand's runtime type. No ulong overload exists, so a wrong-width overload encoded the operand and corrupted the method's instruction stream. Cast to unchecked-long so the operand hits the Int64 overload, same shape as the UInt32 fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
load-constant UInt64passes(unchecked-long k)toil/ldc-i8so the operand reaches mage as alongmatching theldc.i8opcode. A rawUInt64hit mage's reflectiveEmitfallthrough, which has noulongoverload and encoded the operand through a wrong-width one, corrupting the instruction stream.UInt64/MaxValuecoverage to theunsigned-constantsliteral test.magic.core.clj.dllbootstrap binary.