Skip to content

fix(compiler): load UInt64 constants as raw bits #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skydread1 merged 2 commits into from
Jul 23, 2026
Merged

fix(compiler): load UInt64 constants as raw bits #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
270a751
fix(compiler): load UInt64 constants as raw bits (#88)
skydread1 Jul 22, 2026
bbcf1bd
chore(bootstrap): refresh magic.core DLL for UInt64 constant fix (#88)
skydread1 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion magic-compiler/dll-sources.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
magic.analyzer.untyped_passes {:source "magic-compiler/src/magic/analyzer/untyped_passes.clj", :sha256 "19e7f4f2a357f2c265e373dcb1175f336baaf09b5d380744433a4d25f87c4a94"}
magic.analyzer.util {:source "magic-compiler/src/magic/analyzer/util.clj", :sha256 "452824e951159fc291ab3d0055ca6a8c92a13afb626036041223f2cf0ce8759f"}
magic.api {:source "magic-compiler/src/magic/api.clj", :sha256 "0ca4634ad93b01ff6cec5e8d04b022af1cd6b694d9a9529da46c704d89773df1"}
magic.core {:source "magic-compiler/src/magic/core.clj", :sha256 "586cce9ec3c0d5c5bccf153867db65a3b3f978ca234ff1615c063fd6a16ca6dd"}
magic.core {:source "magic-compiler/src/magic/core.clj", :sha256 "67dd98a3e6da08db737855da9786090331c2763a1a6a395857d6528b09169ba6"}
magic.emission {:source "magic-compiler/src/magic/emission.clj", :sha256 "6ad018708a5ef365ced1f762ae1c18bc38ef909e73b24751d599e48a72418bfb"}
magic.flags {:source "magic-compiler/src/magic/flags.clj", :sha256 "2557a7162fac069670e7084705608e56780da249be6d95ce80fff985b71c2263"}
magic.interop {:source "magic-compiler/src/magic/interop.clj", :sha256 "17e4d2fbf1a915948b634d9252691c3183e17b25482fdedef1e039a6438cbc98"}
Expand Down
2 changes: 1 addition & 1 deletion magic-compiler/src/magic/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
(il/ldc-i8 k))

(defmethod load-constant UInt64 [k]
(il/ldc-i8 k))
(il/ldc-i8 (unchecked-long k)))

(defmethod load-constant UInt32 [k]
(load-integer k))
Expand Down
4 changes: 3 additions & 1 deletion magic-compiler/test/magic/test/literals.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@

(deftest unsigned-constants
(cljclr=magic UInt32/MaxValue)
(clojure.test/is (= "4294967295" (str UInt32/MaxValue))))
(clojure.test/is (= "4294967295" (str UInt32/MaxValue)))
(cljclr=magic UInt64/MaxValue)
(clojure.test/is (= "18446744073709551615" (str UInt64/MaxValue))))

(deftest sets
(cljclr=magic #{}))
Expand Down
Binary file modified nostrand/references/magic.core.clj.dll
View file
Open in desktop
Binary file not shown.
Loading