Fix implicit nullable types - #290
Open
chillbram wants to merge 1 commit into
Open
Conversation
This behavior has been been [deprecated since PHP 8.4](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types). This has no impact on the rest of the code. This does not seem to be a breaking change as PHP already internally converts the method signature from e.g. `callable` to `?callable` when it detects an implicitly nullable parameter. Therefore, the method signatures are "the same" and code that overrides these methods is not affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior has been been deprecated since PHP 8.4. This has no impact on the rest of the code.
This does not seem to be a breaking change as PHP already internally converts the method signature from e.g.
callableto?callablewhen it detects an implicitly nullable parameter. Therefore, the method signatures are "the same" and code that overrides these methods is not affected.