Skip to content

Fix implicit nullable types #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chillbram wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix implicit nullable types #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Models/Entity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,7 @@ public function getSiblingsRange($from, $to = null, array $columns = ['*'])
*
* @return Builder
*/
private function buildSiblingQuery(Builder $builder, $id, callable $positionCallback = null)
private function buildSiblingQuery(Builder $builder, $id, ?callable $positionCallback = null)
{
$parentIdColumn = $this->getParentIdColumn();
$positionColumn = $this->getPositionColumn();
Expand Down Expand Up @@ -1759,12 +1759,12 @@ public static function getTreeByQuery(Builder $query, array $columns = ['*'])
* Saves models from the given attributes array.
*
* @param array $tree
* @param EntityInterface $parent
* @param EntityInterface|null $parent
*
* @return Collection
* @throws Throwable
*/
public static function createFromArray(array $tree, EntityInterface $parent = null)
public static function createFromArray(array $tree, ?EntityInterface $parent = null)
{
$entities = [];

Expand Down