fix(tv-motion): route TvFocusScrollWrapper through the motion profile - #285
Merged
ghbarker merged 1 commit intoSep 8, 2026
Merged
Conversation
PR #283 fixed the six row-widget scroll-follow sites but missed the shared TvFocusScrollWrapper — a completely separate mechanism behind every YouTube/Reddit/Lemmy/IPTV results row, the episode list, and the cloud/PikPak/Premiumize file browsers. It hardcoded a flat 200ms glide with no profile branch at all, so on any of those lists the Smooth/ Snappy toggle changed nothing, matching the "does absolutely nothing" report even after #283 landed. Snappy keeps its shipped 200ms glide unchanged; smooth now resolves to AppMotion.tvScroll (260ms), same convention as every other migrated site. Added a regression test verified to fail against the pre-fix 200ms literal and pass after.
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TvFocusScrollWrapper, a separate shared widget behind every YouTube/Reddit/Lemmy/IPTV results row, the episode list, and the cloud/PikPak/Premiumize file browsers.AppMotion.tvScroll(260ms), same convention as the already-migrated sites.Test plan
tv_focus_scroll_wrapper_motion_profile_test.dart), confirmed to fail against the pre-fix 200ms literal and pass aftertv_focus_scroll_wrapper_origin_test.dart/tv_focus_scroll_wrapper_import_identity_test.dart/tv_motion_profile_scroll_sites_test.dartall still passflutter analyzeclean on changed files