fix(tv-motion): route Canvas Home stage's rail-switch through the motion profile - #286
Merged
ghbarker merged 1 commit intoSep 8, 2026
Conversation
…ion profile Canvas is the shipped default TV Home layout (pinned by tv_home_stage_layouts_pin_test.dart), and it doesn't scroll at all — DPAD up/down swaps the bottom shelf to a different rail via an AnimatedSwitcher crossfade, a completely separate mechanism from the row-widget scroll-follow sites #283/#285 already fixed. That crossfade hardcoded a flat 200ms with no profile branch, and being a plain fade with no spatial motion it read as an instant cut regardless of duration — so on the default layout, Smooth/Snappy visibly changed nothing for the one interaction most likely to be described as "scrolling through catalogues". Snappy keeps the shipped 200ms; smooth now resolves through AppMotion.tvScroll (260ms). Added a slide to the crossfade so the switch reads as motion rather than a cut. Added a regression test verified to fail against the pre-fix flat 200ms and pass after.
This was referenced Sep 8, 2026
ghbarker
added a commit
that referenced
this pull request
Sep 8, 2026
Revert #286 only (Canvas rail-switch motion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnimatedSwitchercrossfade, a completely separate mechanism from the row-widget scroll-follow sites fix(tv-motion): route the pre-#276 scroll-follow sites through the TV motion profile #283/fix(tv-motion): route TvFocusScrollWrapper through the motion profile #285 already fixed.AppMotion.tvScroll(260ms). Added a slide to the crossfade so the switch reads as motion rather than a cut.Test plan
canvas_stage_motion_profile_test.dart), confirmed to fail against the pre-fix flat 200ms and pass aftercanvas_stage_origin_test.dart/canvas_tab_window_origin_test.dart/tv_home_stage_layouts_pin_test.dartall still passflutter analyzeclean on changed files