Skip to content

[SYCL] Update E2E to use access_mode [2/3] - #22843

Open
KornevNikita wants to merge 2 commits into
intel:syclfrom
KornevNikita:upd-sycl-e2e-access-mode-2
Open

[SYCL] Update E2E to use access_mode [2/3]#22843
KornevNikita wants to merge 2 commits into
intel:syclfrom
KornevNikita:upd-sycl-e2e-access-mode-2

Conversation

@KornevNikita

@KornevNikita KornevNikita commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
1st - #22842

access::mode is deprecated in favor of access_mode.
PR to add deprecations: intel#22803
@KornevNikita KornevNikita changed the title [SYCL] Update E2E to use access_mode [1/3] [SYCL] Update E2E to use access_mode [2/3] Jul 31, 2026
@KornevNikita
KornevNikita requested a review from Copilot July 31, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is the second step in the E2E update series to migrate tests off sycl::access::mode and onto sycl::access_mode, aligning the test suite with the deprecation/migration work in the linked PRs.

Changes:

  • Replaced sycl::access::mode::* (and access::mode::*) usages with sycl::access_mode::* (and access_mode::*) across a wide set of E2E tests.
  • Updated various accessor template arguments and get_access call sites to use access_mode consistently (including host accessors and image accessors).
  • Adjusted a few using aliases and constexpr mode variables to reference access_mode.

Reviewed changes

Copilot reviewed 106 out of 106 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sycl/test-e2e/XPTI/kernel/basic.cpp Switch buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/XPTI/buffer/recursion.cpp Replace sycl::access::mode with sycl::access_mode in buffer accessor creation.
sycl/test-e2e/XPTI/buffer/in_cycle.cpp Replace sycl::access::mode with sycl::access_mode in buffer accessor creation.
sycl/test-e2e/WorkGroupStatic/work_group_static_memory_namespace_scope.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/WorkGroupScratchMemory/dynamic_allocation.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/WeakObject/weak_object_utils.hpp Update host_accessor mode template args to sycl::access_mode.
sycl/test-e2e/USM/math.cpp Update buffer accessor mode template args to s::access_mode.
sycl/test-e2e/Tracing/image_printers.cpp Update constexpr access mode value to sycl::access_mode.
sycl/test-e2e/SubGroupMask/Basic.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/SubGroup/reduce.hpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/SubGroup/common.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/SpecConstants/2020/vector-convolution-demo.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/SpecConstants/2020/kernel-bundle-api.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Scheduler/ReleaseResourcesTest.cpp Update type alias from sycl::access::mode to sycl::access_mode.
sycl/test-e2e/Scheduler/InOrderQueueDeps.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Scheduler/DataMovement.cpp Update type alias from sycl::access::mode to sycl::access_mode.
sycl/test-e2e/Sampler/unnormalized-none-nearest.cpp Update image/buffer accessor mode template args to access_mode.
sycl/test-e2e/Sampler/unnormalized-clampedge-linear-float.cpp Update image/buffer accessor mode template args to access_mode.
sycl/test-e2e/Sampler/normalized-repeat-nearest.cpp Update image/buffer accessor mode template args to access_mode.
sycl/test-e2e/Sampler/normalized-none-linear-float.cpp Update image/buffer accessor mode template args to access_mode.
sycl/test-e2e/Sampler/normalized-clampedge-nearest.cpp Update image/buffer accessor mode template args to access_mode.
sycl/test-e2e/Sampler/normalized-clamp-linear-float.cpp Update image/buffer accessor mode template args to access_mode.
sycl/test-e2e/Regression/static-buffer-dtor.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Regression/reduction_resource_leak_dw.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Regression/nontrivial_device_copyable_value.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Regression/msvc_crt.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Regression/kernel_unnamed.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Regression/isordered.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Regression/implicit_atomic_conversion.cpp Update atomic accessor mode template arg from access::mode::atomic to access_mode::atomic.
sycl/test-e2e/Regression/fsycl-host-compiler.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Regression/event_destruction.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Regression/build_log.cpp Mass update of get_access<access::mode::*> to get_access<access_mode::*>.
sycl/test-e2e/Reduction/reduction_utils.hpp Update get_access template args from access::mode to access_mode.
sycl/test-e2e/Reduction/reduction_range_N_vars.cpp Update constexpr access mode variables to access_mode.
sycl/test-e2e/Reduction/reduction_nd_N_vars.cpp Update constexpr access mode variables to access_mode.
sycl/test-e2e/Reduction/reduction_nd_lambda.cpp Update template non-type parameter from access::mode to access_mode.
sycl/test-e2e/OptionalKernelFeatures/throw-exception-for-out-of-registers-on-kernel-launch.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/KernelParams/non-standard-layout.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/KernelCompiler/spirv.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/KernelCompiler/opencl.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/InorderQueue/in_order_buffs.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/InlineAsm/asm_no_output.cpp Update output buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/InlineAsm/asm_loop.cpp Update input/output buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/InlineAsm/asm_float_neg.cpp Update input/output buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/InlineAsm/asm_decl_in_scope.cpp Update input/output buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/InlineAsm/asm_8_empty.cpp Update output buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/InlineAsm/asm_16_matrix_mult.cpp Update output buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/HostInteropTask/interop-task-hip.cpp Update mode::* buffer accessor usages to sycl::access_mode::*.
sycl/test-e2e/HostInteropTask/host-task-failure.cpp Update mode::* buffer accessor usages to sycl::access_mode::*.
sycl/test-e2e/HierPar/hier_par_basic.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/GroupLocalMemory/group_local_memory.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/GroupAlgorithm/barrier.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Functor/functor_inheritance.cpp Update constexpr access mode value to sycl::access_mode.
sycl/test-e2e/FreeFunctionKernels/accessor_as_kernel_parameter.cpp Update accessor mode template args in signatures and declarations to sycl::access_mode.
sycl/test-e2e/Experimental/reusable_events/out_of_order_queue_signal.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Experimental/reusable_events/event_reuse.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Experimental/reusable_events/cross_queue_dependency.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Experimental/launch_queries/max_sub_groups.cpp Update accessor mode template args to sycl::access_mode.
sycl/test-e2e/EnqueueNativeCommand/custom-command-hip.cpp Update mode::* buffer accessor usages to sycl::access_mode::*.
sycl/test-e2e/DotProduct/dot_product_int_test.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp Update constexpr access mode variables to s::access_mode.
sycl/test-e2e/DeviceLib/math_test_marray_vec_common.hpp Update accessor mode template args from access::mode to access_mode within macros.
sycl/test-e2e/DeviceLib/math_fp64_windows_test.cpp Update constexpr access mode variables to s::access_mode.
sycl/test-e2e/DeviceLib/ITTAnnotations/atomic.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/DeviceLib/imf/fp64_test.cpp Update constexpr access mode variables to s::access_mode.
sycl/test-e2e/DeviceLib/cmath_test.cpp Update constexpr access mode variables to s::access_mode.
sycl/test-e2e/DeviceLib/c99_complex_math_fp64_test.cpp Update constexpr access mode variable to s::access_mode.
sycl/test-e2e/DeviceLib/built-ins/vector_integer.cpp Update buffer accessor mode template args to s::access_mode.
sycl/test-e2e/DeviceLib/built-ins/scalar_relational.cpp Update buffer accessor mode template args to s::access_mode.
sycl/test-e2e/DeviceLib/built-ins/scalar_integer.cpp Update buffer accessor mode template args to s::access_mode.
sycl/test-e2e/DeviceLib/built-ins/nan.cpp Update buffer accessor mode template args to s::access_mode.
sycl/test-e2e/DeviceLib/bfloat16_conversion_test.hpp Update constexpr access mode variables to access_mode.
sycl/test-e2e/DeviceGlobal/device_global_operator_passthrough.hpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/DeviceArchitecture/device_architecture_on_device_aot.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/DeprecatedFeatures/DiscardEvents/discard_events_accessors.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/ClusterLaunch/enqueueLaunchCustom_check_event_deps.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Basic/use_pinned_host_memory.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Basic/swizzle_op.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/range_offset_fit_in_int.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Basic/parallel_for_indexers.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/multisource_spv_obj.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/multi_ptr_legacy.hpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/kernel_info_attr.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/kernel_bundle/kernel_bundle_api.cpp Update buffer accessor mode template args to sycl::access_mode.
sycl/test-e2e/Basic/image/image_write.h Update image/buffer accessor mode template args from s::access::mode to s::access_mode.
sycl/test-e2e/Basic/image/image_read.h Update image/buffer accessor mode template args from s::access::mode to s::access_mode.
sycl/test-e2e/Basic/image/image_accessor_readwrite_half.cpp Update image/buffer accessor mode template args from s::access::mode to s::access_mode.
sycl/test-e2e/Basic/image/image_accessor_range.cpp Update image accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/handler/handler_mem_op.cpp Update accessor mode template args from access::mode to access_mode in handler memory op tests.
sycl/test-e2e/Basic/half_type.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/group_async_copy.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/free_function_queries/free_function_queries.cpp Update accessor mode template args to sycl::access_mode for free-function query tests.
sycl/test-e2e/Basic/event_release.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/device_event.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/built-ins.cpp Update buffer accessor mode template args to s::access_mode.
sycl/test-e2e/Basic/buffer/native_buffer_creation_flags.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/buffer/buffer_container.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Basic/alloc_pinned_host_memory.cpp Update buffer accessor mode template args from access::mode to access_mode.
sycl/test-e2e/AtomicRef/xor.h Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/AtomicRef/or.h Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/AtomicRef/load.h Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/AtomicRef/atomic_memory_order_seq_cst.cpp Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/AtomicRef/and.h Update accessor mode template args from access::mode to access_mode.
sycl/test-e2e/Assert/Inputs/kernels_in_file2.cpp Update mode::* accessor usage to sycl::access_mode::*.
sycl/test-e2e/Assert/assert_in_one_kernel.hpp Update mode::* accessor usage to sycl::access_mode::*.
sycl/test-e2e/AddressCast/khr_dynamic_addrspace_cast.cpp Update buffer accessor mode template args to sycl::access_mode.

Comment thread sycl/test-e2e/Reduction/reduction_utils.hpp
Comment thread sycl/test-e2e/Basic/event_release.cpp
Comment thread sycl/test-e2e/AtomicRef/and.h
@KornevNikita
KornevNikita marked this pull request as ready for review July 31, 2026 15:39
@KornevNikita
KornevNikita requested review from a team as code owners July 31, 2026 15:39
@KornevNikita

Copy link
Copy Markdown
Contributor Author

failure: #22099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants