Skip to content

[PB-6258] feat: send global search filters server-side through the SDK - #2069

Open
victor-ferro wants to merge 2 commits into
masterfrom
PB-6258-search-filters-sdk
Open

[PB-6258] feat: send global search filters server-side through the SDK#2069
victor-ferro wants to merge 2 commits into
masterfrom
PB-6258-search-filters-sdk

Conversation

@victor-ferro

@victor-ferro victor-ferro commented Jul 24, 2026

Copy link
Copy Markdown

Description

First of a 4-PR stack implementing advanced search filters for the global search (PB-6258).

Adds a SearchFilters state and a search.service.ts that builds GlobalSearchOptions and sends the search through the SDK, moving filtering server-side. The legacy client-side filtering (which only operated on the 10 returned results) and its filter chips are removed.

⚠️ Blocked by internxt/sdk#429: this PR uses GlobalSearchOptions, SearchFileCategory and the new getGlobalSearchItems signature, not published yet. CI will stay red until that SDK version ships; then a final commit will bump @internxt/sdk in package.json + yarn.lock and the PR will be marked ready for review.

Related Issues

Relates to PB-6258 (JIRA).

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

  • Unit tests for search.service.ts.
  • Manual testing against the local backend (drive-server-wip branch PB-6630) with the SDK linked, verifying query params and results in the browser.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96c8d9d
Status: ✅  Deploy successful!
Preview URL: https://abe35a9e.drive-web.pages.dev
Branch Preview URL: https://pb-6258-search-filters-sdk.drive-web.pages.dev

View logs

@sonarqubecloud

Copy link
Copy Markdown

@victor-ferro
victor-ferro marked this pull request as ready for review July 29, 2026 14:42

@CandelR CandelR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, waiting to add the sdk to approve in order to not merge by error

@victor-ferro victor-ferro self-assigned this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants