Fold SafeFeedback into Feedback delay options - #166
Merged
Conversation
Feedback is now the single closed-loop entry point. The delay policy is a visible option instead of a sibling function: exact by default (internal LFT delays), WithApproximatedDelays/WithPadeOrder/ WithThiranOrder for a delay-free rational model. Variadic options keep existing Feedback callers source-compatible. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feedbackis now the single closed-loop entry point;SafeFeedbackis removedWithApproximatedDelays()/WithPadeOrder(n)/WithThiranOrder(n)for a delay-free rational modelFeedbackcall sites source-compatible;safe_feedback.gorenamed tofeedback_delay.go; README, interface diagram, mutation audit, and generated SVG updatedTesting
go fix ./...andgo vet ./...cleango test -count=1), including migratedTestFeedbackApprox_*behavior tests asserting the same error sentinels (ErrFractionalDelay,ErrSingularTransform,ErrDomainMismatch) and Padé/Thiran/absorb semantics as before🤖 Generated with Claude Code