[7.0] Changelog: Removing LegacyPropertyManagementTrait

[Hackwar]

Summary of Changes

The Joomla\CMS\Changelog\Changelog class uses the LegacyPropertyManagementTrait, which is deprecated. The trait is deprecated because it basically disables the whole visibility system of properties in PHP. This PR removes that trait from this class and changes the core code to use the new way this class works.

This is a b/c break, since the properties now have been changed from protected to public (remember that the trait was there to directly circumvent that again.) and of course the trait has been removed.

Testing Instructions

Copy the following XML into an XML file of your choosing: (for example changelog.xml)

<changelogs>
	<changelog>
		<element>pkg_ru-RU</element>
		<type>package</type>
		<version>5.2.2.1</version>
		<security>
			<item>Item A</item>
			<item><![CDATA[<h2>You MUST replace this file</h2>]]></item>
		</security>
		<fix>
			<item>Item A</item>
			<item>Item b</item>
		</fix>
	</changelog>
</changelogs>

Put the file somewhere where you could access it via a URL, for example simply in the root of the site you are testing this on.
Install a random outdated extension, for example a language pack and then go into the database into the #__updates table and edit the changelog column of the installed extension (e.g. the language pack) and insert the URL to the XML file into it.
Go to the update view in the backend and click on the changelog button next to the available update.

Actual result BEFORE applying this Pull Request

You get a view of the changelog.

Expected result AFTER applying this Pull Request

You still get a view of the changelog, but the class behind it has been refactored to not use the outdated code.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org: Removal of LegacyPropertyManagementTrait and CMSObject Manual#615

• No documentation changes for manual.joomla.org needed

[exlemor]

I have tested this item ✅ successfully on c1f60f1

I have tested this successfully.

NOT sure if this important but during my testing I tried Enabling (and disabling) Log Everything through different testing cycles in the Global Configuration and WHEN it is enabled, the Changelog button does not show because it seems that something removes the data in the Changelogurl column in the __updates table... - Just thought you would want to know in case that wasn't normal.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44897.}

[sdwjoomla]

I have tested this item ✅ successfully on 2b6b18d

Did not see any changes in the output as expected

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44897.}

[Hackwar]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44897.}

[tecpromotion]

I have tested this item ✅ successfully on d1d650e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44897.}

[softforge]

Thank you @Hackwar we have rebased to 6.1 as its B/C

[HLeithner]

Does it make sense to make the properties public writable? waiting for php 8.4 would allow us to use property hooks or use setter/getter?

[richard67]

@HLeithner @tecpromotion @laoneo As there are unresolved review comments, shall I remove RTC?

[bembelimen]

Thx