[7.0] Changelog: Removing LegacyPropertyManagementTrait

administrator/components/com_installer/src/Model/ManageModel.php

@@ -454,9 +454,9 @@ public function loadChangelog($eid, $source)
         ];
 
         foreach (array_keys($entries) as $name) {
-            $field = $changelog->get($name);
+            $field = $changelog->$name;
             if ($field) {
-                $entries[$name] = $changelog->get($name)->data;
+                $entries[$name] = $changelog->{$name}->data;
             }
         }
 

libraries/src/Changelog/Changelog.php

@@ -11,7 +11,6 @@
 
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\Log\Log;
-use Joomla\CMS\Object\LegacyPropertyManagementTrait;
 use Joomla\CMS\Version;
 use Joomla\Http\HttpFactory;
 use Joomla\Registry\Registry;
@@ -27,87 +26,85 @@
  */
 class Changelog
 {
-    use LegacyPropertyManagementTrait;
-
     /**
      * Update manifest `<element>` element
      *
      * @var    string
      * @since  4.0.0
      */
-    protected $element;
+    public $element;
 
     /**
      * Update manifest `<type>` element
      *
      * @var    string
      * @since  4.0.0
      */
-    protected $type;
+    public $type;
 
     /**
      * Update manifest `<version>` element
      *
      * @var    string
      * @since  4.0.0
      */
-    protected $version;
+    public $version;
 
     /**
      * Update manifest `<security>` element
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $security = [];
+    public $security = [];
 
     /**
      * Update manifest `<fix>` element
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $fix = [];
+    public $fix = [];
 
     /**
      * Update manifest `<language>` element
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $language = [];
+    public $language = [];
 
     /**
      * Update manifest `<addition>` element
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $addition = [];
+    public $addition = [];
 
     /**
      * Update manifest `<change>` elements
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $change = [];
+    public $change = [];
 
     /**
      * Update manifest `<remove>` element
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $remove = [];
+    public $remove = [];
 
     /**
      * Update manifest `<maintainer>` element
      *
      * @var    array
      * @since  4.0.0
      */
-    protected $note = [];
+    public $note = [];
 
     /**
      * List of node items
@@ -139,7 +136,7 @@ class Changelog
      * @var    \stdClass
      * @since  4.0.0
      */
-    protected $currentChangelog;
+    public $currentChangelog;
 
     /**
      * The version to match the changelog
@@ -155,15 +152,15 @@ class Changelog
      * @var    \stdClass
      * @since  4.0.0
      */
-    protected $latest;
+    public $latest;
 
     /**
      * Update manifest `<folder>` element
      *
      * @var    string
      * @since  5.1.1
      */
-    protected $folder;
+    public $folder;
 
     /**
      * Gets the reference to the current direct parent