Skip to content

VAP/MAP improvements - #4217

Merged
kcp-ci-bot merged 9 commits into
kcp-dev:mainfrom
ntnn:map-men-map-men-map-map-map-vap-vap
Jun 22, 2026
Merged

VAP/MAP improvements#4217
kcp-ci-bot merged 9 commits into
kcp-dev:mainfrom
ntnn:map-men-map-men-map-map-map-vap-vap

Conversation

@ntnn

@ntnn ntnn commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Thank you for noticing the branch name. Yes, I am a comedic genius.

  1. VAP and MAP use dynamic rest mapper
  2. MAP shared the underyling TypeConverterManager per source policy target cluster bounded by its per-cluster context

Doesn't quite fix #4216 but kinda does.

What Type of PR Is This?

/kind bug
/kind feature

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2026
@ntnn

ntnn commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

They all fail on TestMutatingAdmissionPolicyCrossWorkspaceAPIBinding - I'm thinking the sync wait is the problem.

mjudeikis
mjudeikis approved these changes Jun 20, 2026
View reviewed changes

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2026
@kcp-ci-bot

kcp-ci-bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 08b25f161b104c0f67522b6ae5f34487a9447137

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2026
@mjudeikis

mjudeikis commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

/retest

@ntnn
ntnn force-pushed the map-men-map-men-map-map-map-vap-vap branch from f249b7a to b0f6029 Compare June 20, 2026 16:29
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2026
@kcp-ci-bot
kcp-ci-bot requested a review from mjudeikis June 20, 2026 16:29
@ntnn
Add per-policy-cluster TypeConverterManager map for MAP
b19822b 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
ntnn force-pushed the map-men-map-men-map-map-map-vap-vap branch from b0f6029 to 1416471 Compare June 21, 2026 17:22
@ntnn
ntnn force-pushed the map-men-map-men-map-map-map-vap-vap branch from 1416471 to ac3bd6e Compare June 21, 2026 17:32
mjudeikis
mjudeikis approved these changes Jun 22, 2026
View reviewed changes

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2026
@kcp-ci-bot

kcp-ci-bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 5244d3843c194f9f8a053ba0c1ecc6c0211a1561

@kcp-ci-bot

kcp-ci-bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ntnn

ntnn commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/retest

Flake adressed by #4219

@ntnn

ntnn commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/retest

metrics endpoint flake

@kcp-ci-bot
kcp-ci-bot merged commit 17c113d into kcp-dev:main Jun 22, 2026
15 checks passed
@SimonTheLeg

SimonTheLeg commented Jul 16, 2026

Copy link
Copy Markdown
Member

/cherrypick release-0.32

@kcp-ci-bot

kcp-ci-bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@SimonTheLeg: new pull request created: #4276

Details

In response to this:

/cherrypick release-0.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot mentioned this pull request Jul 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: something is spamming bound CRD resolution for CachedResource/CachedResourceEndpointSlice

4 participants

@ntnn @kcp-ci-bot @mjudeikis @SimonTheLeg