Use a Windows-compatible method of retrieving filepaths from interpre… - #24
Merged
Merged
Conversation
Kind 2 can only read local files, so interpret(URI, ...) now converts its argument with a toLocalPath helper: scheme-less URIs are used as plain paths, file: URIs have their query and fragment dropped before Paths.get, and anything else (other schemes, opaque or invalid paths) raises a Kind2Exception instead of passing Kind 2 a nonexistent path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
getAbsoluteFilepath()instead oftoURI().getPath()when storing the path of temproary interpreter input files. The ladder produces filepaths that Windows does not recognize, while the former is compatible with Linux and Windows. An example of the change:/C:/Users/user/AppData/Local/Temp/kind2-interpreter-1234.jsonchanges to
C:\Users\user\AppData\Local\Temp\kind2-interpreter-1234.jsonWhere the second path is recognized by Windows, and the first is not.