Skip to content

Use a Windows-compatible method of retrieving filepaths from interpre… #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-larraz merged 3 commits into from
Sep 15, 2026
Merged

Use a Windows-compatible method of retrieving filepaths from interpre… #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e4dcdf
Use a Windows-compatible method of retrieving filepaths from interpre…
Jabe03 Sep 15, 2026
2ce4aec
Improve file path handling for interpreter input to support various U…
Jabe03 Sep 15, 2026
50399af
Resolve interpreter URIs to local paths with clear errors
daniel-larraz Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions src/main/java/edu/uiowa/cs/clc/kind2/api/Kind2Api.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.URI;
import java.net.URISyntaxException;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
Expand Down Expand Up @@ -273,11 +276,11 @@ public void done() {}
/**
* Runs the Kind 2 interpreter on a Lustre file.
*
* @param uri the Lustre file to interpret
* @param uri the Lustre file to interpret, as a scheme-less path or a {@code file:} URI
* @param main the main node to interpret
* @param json the input values, as a json string
* @return the interpreter output
* @throws Kind2Exception if Kind 2 fails to run
* @throws Kind2Exception if {@code uri} is not a local file or Kind 2 fails to run
*/
public String interpret(URI uri, String main, String json) {
List<String> options = new ArrayList<>();
Expand All @@ -288,8 +291,8 @@ public String interpret(URI uri, String main, String json) {
options.add("--enable");
options.add("interpreter");
options.add("--interpreter_input_file");
options.add(ApiUtil.writeInterpreterFile(json).toURI().getPath());
options.add(uri.getPath());
options.add(ApiUtil.writeInterpreterFile(json).getAbsolutePath());
options.add(toLocalPath(uri).toString());
ProcessBuilder builder = new ProcessBuilder(options);
try {
Process process = builder.start();
Expand All @@ -308,6 +311,26 @@ public String interpret(URI uri, String main, String json) {
}
}

/**
* Converts a URI to a path on the local file system, since Kind 2 can only read local files.
* Scheme-less URIs are treated as plain paths; the query and fragment of a file: URI are ignored.
*/
private static Path toLocalPath(URI uri) {
String scheme = uri.getScheme();
if ((scheme != null && !"file".equalsIgnoreCase(scheme)) || uri.getPath() == null) {
throw new Kind2Exception("Not a local file URI: " + uri);
}
try {
if (scheme == null) {
return Paths.get(uri.getPath());
}
// Keep the authority so Windows UNC paths (file://server/share/...) still resolve.
return Paths.get(new URI("file", uri.getAuthority(), uri.getPath(), null, null));
} catch (URISyntaxException | IllegalArgumentException e) {
throw new Kind2Exception("Not a local file URI: " + uri, e);
}
}

/**
* Runs the Kind 2 interpreter on a Lustre program.
*
Expand All @@ -326,7 +349,7 @@ public String interpret(String program, String main, String json) {
options.add("--enable");
options.add("interpreter");
options.add("--interpreter_input_file");
options.add(ApiUtil.writeInterpreterFile(json).toURI().getPath());
options.add(ApiUtil.writeInterpreterFile(json).getAbsolutePath());
ProcessBuilder builder = new ProcessBuilder(options);
try {
Process process = builder.start();
Expand Down Expand Up @@ -981,7 +1004,7 @@ public void setInterpreterInputFile(String interpreterInputFile) {
*/
public void setInterpreterInput(String json) {
File interpreterFile = ApiUtil.writeInterpreterFile(json);
this.interpreterInputFile = interpreterFile.toURI().getPath();
this.interpreterInputFile = interpreterFile.getAbsolutePath();
}

/**
Expand Down