WIP: Add v1beta2 contract fields (initialization, conditions) to API types#6199
WIP: Add v1beta2 contract fields (initialization, conditions) to API types#6199willie-yao wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: William Yao <william2000yao@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6199 +/- ##
==========================================
- Coverage 43.67% 43.57% -0.10%
==========================================
Files 289 289
Lines 25495 25551 +56
==========================================
Hits 11134 11134
- Misses 13559 13615 +56
Partials 802 802 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
5ff0c6d to
fd61436
Compare
Signed-off-by: William Yao <william2000yao@gmail.com>
fd61436 to
f5111c0
Compare
|
@willie-yao: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@willie-yao: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds the v1beta2 CAPI contract fields to all CAPZ provider API types (Stage 1 of the conditions migration). This is purely additive with no behavioral changes. Controllers will dual-write these fields in a follow-up PR.
General implementation formula:
Changes per type:
These fields are not yet read by CAPI. That only happens when the CRD label is updated to declare v1beta2 contract compliance in a later PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #6136
Special notes for your reviewer:
Contract documentation pages
TODOs:
Release note: