Skip to content

Update build and CI - #329

Merged
David-LP99 merged 13 commits into
rollingfrom
fix/update_build_and_CI
Sep 3, 2026
Merged

David-LP99 merged 13 commits into
rollingfrom
fix/update_build_and_CI

Conversation

@David-LP99

@David-LP99 David-LP99 commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Update the build for updated ros2 rolling images as well as the build of the tests and the CI.

Main changes

  • Bump CMake minimum version to 3.10
  • Add CXX as a language for the tests
  • Change visibility configuration to prevent linking error
  • Update CI for rolling, kilted and lyrical (it is worth mentioning that a micro-ROS-Agent is built for the tests using its own Superbuild, its configuration had to be modified to prevent noise and issues coming from the logger)
  • Add a weekly CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov-commenter

codecov-commenter commented Aug 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.71%. Comparing base (b6e0266) to head (5d95a37).

Additional details and impacted files
@@             Coverage Diff             @@
##           rolling     #329      +/-   ##
===========================================
+ Coverage    46.98%   53.71%   +6.72%     
===========================================
  Files           47      100      +53     
  Lines         1790     5777    +3987     
  Branches       534      930     +396     
===========================================
+ Hits           841     3103    +2262     
- Misses         717     2344    +1627     
- Partials       232      330      +98     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@David-LP99
David-LP99 force-pushed the fix/update_build_and_CI branch from 86d21b7 to 3a99d64 Compare August 21, 2026 21:29
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@David-LP99
David-LP99 force-pushed the fix/update_build_and_CI branch from 3a99d64 to 9eb03ad Compare August 24, 2026 07:47
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one NIT. Take into account that rolling branch might fail because it is an unstable branch.

Comment thread .github/workflows/ubuntu-ci.yml Outdated
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@David-LP99
David-LP99 merged commit fdd4c91 into rolling Sep 3, 2026
4 checks passed
@David-LP99
David-LP99 deleted the fix/update_build_and_CI branch September 3, 2026 13:56
@David-LP99

Copy link
Copy Markdown
Contributor Author

@mergify backport humble jazzy kilted

@mergify

mergify Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

backport humble jazzy kilted

✅ Backports have been created

Details

Cherry-pick of fdd4c91 has failed:

On branch mergify/bp/humble/pr-329
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit fdd4c91.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/ISSUE_TEMPLATE/general-issue.md
	new file:   .github/workflows/ubuntu-ci.yml
	new file:   .github/workflows/weekly-ubuntu-ci.yml
	modified:   rmw_microxrcedds_c/CMakeLists.txt
	modified:   rmw_microxrcedds_c/test/CMakeLists.txt

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/workflows/ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of fdd4c91 has failed:

On branch mergify/bp/jazzy/pr-329
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit fdd4c91.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/ISSUE_TEMPLATE/general-issue.md
	new file:   .github/workflows/ubuntu-ci.yml
	new file:   .github/workflows/weekly-ubuntu-ci.yml
	modified:   rmw_microxrcedds_c/CMakeLists.txt
	modified:   rmw_microxrcedds_c/test/CMakeLists.txt

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/workflows/ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of fdd4c91 has failed:

On branch mergify/bp/kilted/pr-329
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit fdd4c91.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .github/workflows/ubuntu-ci.yml
	new file:   .github/workflows/weekly-ubuntu-ci.yml
	modified:   rmw_microxrcedds_c/CMakeLists.txt
	modified:   rmw_microxrcedds_c/test/CMakeLists.txt

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   .github/ISSUE_TEMPLATE/general-issue.md
	deleted by them: .github/workflows/ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

David-LP99 added a commit that referenced this pull request Sep 3, 2026
* Update build and CI (#329)

* Update build and CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Change base image

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build in CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build visibility

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 2

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Update 'general-issue.md'

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 3

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 4

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use agent test branch to test fix

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use updated agent branch

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Add humble and jazzy to the CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Address suggestions

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
(cherry picked from commit fdd4c91)

# Conflicts:
#	.github/workflows/ci.yml

* Fix conflict

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99 added a commit that referenced this pull request Sep 3, 2026
* Update build and CI (#329)

* Update build and CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Change base image

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build in CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build visibility

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 2

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Update 'general-issue.md'

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 3

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 4

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use agent test branch to test fix

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use updated agent branch

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Add humble and jazzy to the CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Address suggestions

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
(cherry picked from commit fdd4c91)

# Conflicts:
#	.github/ISSUE_TEMPLATE/general-issue.md
#	.github/workflows/ci.yml

* Fix conflict

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix conflict 2

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99 added a commit that referenced this pull request Sep 3, 2026
* Update build and CI (#329)

* Update build and CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Change base image

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build in CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build visibility

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 2

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Update 'general-issue.md'

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 3

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 4

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use agent test branch to test fix

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use updated agent branch

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Add humble and jazzy to the CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Address suggestions

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
(cherry picked from commit fdd4c91)

# Conflicts:
#	.github/workflows/ci.yml

* Fix conflict

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants