Update build and CI - #329
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rolling #329 +/- ##
===========================================
+ Coverage 46.98% 53.71% +6.72%
===========================================
Files 47 100 +53
Lines 1790 5777 +3987
Branches 534 930 +396
===========================================
+ Hits 841 3103 +2262
- Misses 717 2344 +1627
- Partials 232 330 +98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
86d21b7 to
3a99d64
Compare
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
3a99d64 to
9eb03ad
Compare
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
cferreiragonz
left a comment
There was a problem hiding this comment.
LGTM, just one NIT. Take into account that rolling branch might fail because it is an unstable branch.
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
|
@mergify backport humble jazzy kilted |
✅ Backports have been createdDetails
Cherry-pick of fdd4c91 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of fdd4c91 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of fdd4c91 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Update build and CI (#329) * Update build and CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Change base image Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix build in CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix build visibility Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 2 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Update 'general-issue.md' Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 3 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 4 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Use agent test branch to test fix Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Use updated agent branch Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Add humble and jazzy to the CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Address suggestions Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit fdd4c91) # Conflicts: # .github/workflows/ci.yml * Fix conflict Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
* Update build and CI (#329) * Update build and CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Change base image Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix build in CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix build visibility Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 2 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Update 'general-issue.md' Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 3 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 4 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Use agent test branch to test fix Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Use updated agent branch Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Add humble and jazzy to the CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Address suggestions Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit fdd4c91) # Conflicts: # .github/ISSUE_TEMPLATE/general-issue.md # .github/workflows/ci.yml * Fix conflict Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix conflict 2 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
* Update build and CI (#329) * Update build and CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Change base image Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix build in CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix build visibility Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 2 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Update 'general-issue.md' Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 3 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Fix agent build 4 Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Use agent test branch to test fix Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Use updated agent branch Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Add humble and jazzy to the CI Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> * Address suggestions Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit fdd4c91) # Conflicts: # .github/workflows/ci.yml * Fix conflict Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
Description
Update the build for updated ros2 rolling images as well as the build of the tests and the CI.
Main changes
rolling,kiltedandlyrical(it is worth mentioning that a micro-ROS-Agent is built for the tests using its own Superbuild, its configuration had to be modified to prevent noise and issues coming from the logger)