Skip to content

Update build and CI (backport #329) - #332

Merged
David-LP99 merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-329
Sep 3, 2026
Merged

David-LP99 merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-329

Conversation

@mergify

@mergify mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Update the build for updated ros2 rolling images as well as the build of the tests and the CI.

Main changes

  • Bump CMake minimum version to 3.10
  • Add CXX as a language for the tests
  • Change visibility configuration to prevent linking error
  • Update CI for rolling, kilted and lyrical (it is worth mentioning that a micro-ROS-Agent is built for the tests using its own Superbuild, its configuration had to be modified to prevent noise and issues coming from the logger)
  • Add a weekly CI
    This is an automatic backport of pull request Update build and CI #329 done by Mergify.

* Update build and CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Change base image

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build in CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix build visibility

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 2

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Update 'general-issue.md'

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 3

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Fix agent build 4

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use agent test branch to test fix

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Use updated agent branch

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Add humble and jazzy to the CI

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

* Address suggestions

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

---------

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
(cherry picked from commit fdd4c91)

# Conflicts:
#	.github/workflows/ci.yml
@mergify mergify Bot added the conflicts label Sep 3, 2026
@mergify

mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of fdd4c91 has failed:

On branch mergify/bp/jazzy/pr-329
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit fdd4c91.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/ISSUE_TEMPLATE/general-issue.md
	new file:   .github/workflows/ubuntu-ci.yml
	new file:   .github/workflows/weekly-ubuntu-ci.yml
	modified:   rmw_microxrcedds_c/CMakeLists.txt
	modified:   rmw_microxrcedds_c/test/CMakeLists.txt

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/workflows/ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot mentioned this pull request Sep 3, 2026
@mergify

mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.66%. Comparing base (a698d4e) to head (5725f28).

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy     #332      +/-   ##
==========================================
+ Coverage   47.25%   53.66%   +6.41%     
==========================================
  Files          47      100      +53     
  Lines        1784     5754    +3970     
  Branches      530      915     +385     
==========================================
+ Hits          843     3088    +2245     
- Misses        710     2337    +1627     
- Partials      231      329      +98     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@David-LP99
David-LP99 merged commit 5d819d8 into jazzy Sep 3, 2026
4 checks passed
@David-LP99
David-LP99 deleted the mergify/bp/jazzy/pr-329 branch September 3, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants