Fix domain bug in rmw_init (backport #335) - #339
Closed
mergify[bot] wants to merge 1 commit into
Closed
mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit a65078f)
Contributor
Author
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lyrical #339 +/- ##
===========================================
- Coverage 54.94% 54.68% -0.27%
===========================================
Files 102 102
Lines 5917 5918 +1
Branches 943 944 +1
===========================================
- Hits 3251 3236 -15
- Misses 2330 2347 +17
+ Partials 336 335 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a minor bug where the default domain ID is set to 0 ignoring the user's default.
It also adds a comment to clarify how the cleanup process works.
This is an automatic backport of pull request #335 done by Mergify.