Add end-to-end Workday DA setup orchestration - #308
Surendra Goutham (is-goutham) merged 12 commits into
Conversation
|
Review summary
|
|
Retraction — F-1 was based on redacted source rendering I’m withdrawing my earlier token-validation finding. The review surface masked the bearer-header expression as This was not a product defect. The added structural regression coverage is useful, but the original critical finding should not be considered an outstanding or previously confirmed issue. Apologies for the incorrect report. |
|
Updated review finding — checklist state is displayed against the wrong tasks
Render the displayed checklist from the canonical rows or make its titles and order exactly match |
|
Re-reviewed the current head (
The repeated bearer-header concern from automated review is still a tooling redaction artifact, not a source defect. Retry, rollback, and compensating-delete concerns were also excluded. This PR additionally remains blocked on the unresolved state/evidence contracts in its PR 307 base. |
|
Addressed the latest blocker in 469dba5: the rendered checklist now uses the exact canonical tasks.md titles and order, with a structural regression test comparing every visible row. Validation: 17 focused setup tests passed. |
|
Re-reviewed the latest head ( I found no remaining critical issue in this PR's own changes. Good to merge into its stacked base. The overall stack remains held at PR 305. |
The merge-base changed after approval.
3fccc4f to
b0aef72
Compare
b0aef72 to
8838160
Compare
8838160 to
fcb81e4
Compare
fcb81e4 to
65c1c55
Compare
Summary
Validation
python -m pytest tests/setup tests/flightcheck/checks/test_workday_package.py tests/flightcheck/checks/test_workday_saml_certificate.py tests/scripts/test_install_workday_da_extension.py tests/scripts/test_flow_authorization.py -q(107 passed)git diff --checkStacked on #307 and includes #306 as an explicit dependency. Once #306 merges, this branch can be rebased to remove those already-reviewed files from the diff.