Skip to content

Expose Workday setup commands and maker guidance - #309

Merged
nkemms merged 5 commits into
mainfrom
users/gouthams/pr290-09-workday-command-docs
Sep 25, 2026
Merged

nkemms merged 5 commits into
mainfrom
users/gouthams/pr290-09-workday-command-docs

Conversation

@is-goutham

Copy link
Copy Markdown
Contributor

Summary

  • add the dedicated /connect-workday command and surface it in the menu
  • route generic /connect after canonical workspace materialization without requiring runtime readiness first
  • recognize the dedicated command in the repo-root wrong-folder redirect
  • document supported ESS DA HR scope, administrator handoffs, target-environment authorization, and signed-in validation

Validation

  • python -m pytest tests/setup -q (60 passed)
  • git diff --check

Stacked on #308.

@nkemms

nkemms commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Review summary

  • Adds a dedicated Workday command and documentation, but the command is omitted from the pre-readiness exception that must run before command prompts are dispatched.
  • Verdict: do not merge — 1 MAJOR and 1 MINOR finding.
  • Minimum fix: route /connect-workday through the same materialized-workspace exception as /connect; make the discovery tests resilient to harmless Markdown wrapping.

Comment thread solutions/ess-maker-skills/.github/copilot-instructions.md Outdated
Comment thread tests/setup/test_workday_command_discovery.py Outdated
@nkemms

nkemms commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Re-reviewed the current head (1e320f1) against its actual stacked base. I found no blocking issue in PR 309's own command-routing and documentation changes.

The current stacked PR is not merge-ready yet because its PR 308 base still contains the unresolved checklist-mapping issue and inherits PR 307's state/evidence blockers. Once those bases are fixed—or this PR is restacked onto a clean base—this delta is good to merge.

@is-goutham

Copy link
Copy Markdown
Contributor Author

Propagated all upstream review fixes into f480057. Final stacked validation: 871 tests passed and the authorization PowerShell script parsed successfully.

@nkemms

nkemms commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Re-reviewed the latest head (f480057). I found no critical issue in the command-routing or documentation delta.

Good to merge into its stacked base. The overall stack remains held at PR 305.

nkemms
nkemms previously approved these changes Sep 24, 2026
@is-goutham

Copy link
Copy Markdown
Contributor Author

Upstream PR #305 PAC-ring correction propagated cleanly through this branch. Final #309 stack validation after propagation: 943 tests passed; Enable-CosmosDAFlowAuthorization.ps1 parsed successfully.

@is-goutham

Copy link
Copy Markdown
Contributor Author

GitHub stack rebase completed after #302 merged. This branch was rebased linearly onto the updated branch below it and force-pushed with lease. Final rebased #309 validation: 960 relevant tests passed; the 3 excluded router assertions reproduce unchanged on current main; PowerShell parser passed.

@is-goutham
Surendra Goutham (is-goutham) force-pushed the users/gouthams/pr290-09-workday-command-docs branch from b782e41 to cac143b Compare September 25, 2026 00:32
@is-goutham
Surendra Goutham (is-goutham) force-pushed the users/gouthams/pr290-09-workday-command-docs branch 2 times, most recently from c5ac355 to 2c9851c Compare September 25, 2026 00:44
Base automatically changed from users/gouthams/pr290-08-workday-setup-orchestration to main September 25, 2026 00:46
@is-goutham
Surendra Goutham (is-goutham) force-pushed the users/gouthams/pr290-09-workday-command-docs branch from 2c9851c to 76555fd Compare September 25, 2026 00:46
@nkemms
nkemms merged commit bcf2bdc into main Sep 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants