Add ring-aware Workday runtime installer - #305
Surendra Goutham (is-goutham) merged 7 commits into
Conversation
|
Re-reviewed the current head (
The earlier Preprod URL-matching change improved disambiguation among existing profiles, but it does not make |
|
Addressed the latest blockers in 26c76c3: both rings use PAC-supported Public cloud, profile reuse requires the exact normalized environment URL for production and preprod, and auth creation always includes --environment. Validation: 64 targeted tests passed. |
|
Correction to my previous PR 305 review My original statement that At the current head (
Please restore the Preprod mapping and limit environment anchoring to the Preprod path. Prod should retain cloud-only profile selection and creation. |
|
Confirmed against the canonical ring-aware PAC implementation (556a9ae) and the Preprod environment-disambiguation fix (57b5476). I reverted 26c76c3 in 16d591c: PPE again uses the hidden Preprod cloud with exact environment matching and --environment; Production uses Public with cloud-scoped profile reuse and no required environment anchor. Focused validation: 12 passed in ests/scripts/test_install_workday_da_extension.py. |
|
Re-reviewed the latest head ( I found no remaining critical blocker in this PR's own changes. Good to merge. |
|
Follow-up PR: Consider aligning the standalone script's omitted- |
The merge-base changed after approval.
16d591c to
89ade9f
Compare
This reverts commit 26c76c3.
89ade9f to
1245dc3
Compare
Summary
Validation
python -m pytest tests/scripts/test_install_workday_da_extension.py -q(9 passed)python -m py_compile solutions/ess-maker-skills/scripts/install_workday_da_extension.pygit diff --checkStacked on #303.