Prototype DA ServiceNow connection binding(HR Agent + ServiceNow HRSD) - #331
DapheneShao wants to merge 10 commits into
Conversation
Add a DA-GA HR ServiceNow connection workflow with maker-guided physical connection creation, read-only Connectivity discovery, MinimalBot reference binding, and confirmed publish. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Resolve the active operational agent against canonical per-agent setup state, reuse the latest AgentBuilder authentication and publish contracts, and isolate DA ServiceNow routing coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Add deterministic authoring readiness, live topic and connection handling, maker-only binding boundaries, resumable progress, and regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Use the canonical authoring_ready marker in the ServiceNow runtime and remove a stray skill heading character. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Seven moderate findings and one nit remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 4
Open (4)
What changed in this PR
Adds a resumable ServiceNow HRSD connection prototype for the DA-GA Employee Self-Service HR agent, including topic activation, credential discovery, maker-assisted binding, publishing, and progress persistence.
Changes:
- Adds DA ServiceNow routing and resumable workflow guidance.
- Implements topic inspection, updates, credential verification, and attestations.
- Adds authoring-readiness tracking, AgentBuilder updates, and test coverage.
Review status: seven moderate findings and one nit remain unresolved, so changes are required before approval.
| File | Summary |
|---|---|
tests/setup/test_servicenow_da_connect_router.py |
Tests ServiceNow DA routing and resumability. |
tests/setup/test_da_setup_router.py |
Updates setup readiness assertions. |
tests/scripts/test_setup_existing_da.py |
Tests authoring-readiness persistence and migration. |
tests/scripts/test_connect_servicenow_da.py |
Tests ServiceNow workflow behavior. |
tests/scripts/test_agentbuilder.py |
Tests component change-set updates. |
solutions/ess-maker-skills/src/skills/connect/SKILL.md |
Routes DA HR ServiceNow connections. |
solutions/ess-maker-skills/src/skills/connect/servicenow-da/SKILL.md |
Defines the resumable HRSD workflow. |
solutions/ess-maker-skills/scripts/setup_existing_da.py |
Adds authoring-readiness markers and synchronization. |
solutions/ess-maker-skills/scripts/connect_servicenow_da.py |
Implements inspection, mutations, credentials, publishing, and attestations. |
solutions/ess-maker-skills/scripts/agentbuilder.py |
Adds scopes and component updates. |
solutions/ess-maker-skills/.github/prompts/connect.prompt.md |
Updates connection admission and resume rules. |
solutions/ess-maker-skills/.github/copilot-instructions.md |
Updates the global readiness gate. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9e8cfc7-07a1-469b-80f6-99a9cbb7aee6
Preserve the HRSD authoring and connect flow while integrating current Workday setup, FlightCheck, and connector telemetry behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
DapheneShao please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|

Summary
/connect servicenowprototype for the active Employee Self-Service (HR) DA-GA agent and its ServiceNow HRSD integration/setupauthoring_readyhandoff rather than aggregate connection readinessConnected, and persist agent-scoped non-secret progressScope
This PR intentionally proves the HR Agent + ServiceNow HRSD vertical slice only. It does not claim IT Agent / ITSM support.
The IT DA package has a similar ServiceNow shape, but ITSM has not yet been live-validated through this workflow. A follow-up PR will generalize the shared flow through HRSD/ITSM product profiles and add Employee Self-Service (IT) + ServiceNow ITSM support, tests, and live validation. Keeping that work separate preserves this PR as the already-proven HRSD baseline.
Automation boundary
Automated
Maker-assisted
The Copilot Studio UI binding endpoint was identified and live-observed, but the ESS ADK client cannot request the required
PowerVirtualAgents.Tokens.Readpermission because first-party preauthorization is unavailable. The prototype therefore does not reuse browser tokens or treat MinimalBotConnectionReferenceUpdateas Agent binding.Live POC evidence
dev184242with statusConnectedValidation
86 passedacross the focused ServiceNow implementation, setup-state, AgentBuilder, and routing suitesgit diff --checkpassedADO: https://o365exchange.visualstudio.com/O365%20Core/_workitems/edit/7735182/