Bump Proc to 0.14.0, fix release-notes CLI invocation, fix container tags - #15
Merged
Merged
Conversation
…tags Proc was pinned at 0.6.2, and exec() manually wrapped every argument in quotes (a workaround for that old version's shell-based invocation). Bumped to 0.14.0 and dropped the manual quoting to match curb's exec: Proc 0.14+ passes args directly to the OS with no shell expansion. The old double quoting was actively corrupting -p:ContainerImageTags="edge;latest;0.14.0" on this repo's own tagged release - MSBuild saw four quote characters instead of two and rejected `latest` as an unknown switch (MSB1006), failing the "Build container image" CI step. Verified the fixed exec produces a working multi-tag container push locally. release-notes was pinned at 0.5.2, a net6.0 build - the CI runner's SDKs start at 8.0, so `dotnet release-notes ...` would fail with "You must install or update .NET to run this application." on the next tagged release. Bumped the pin to 0.11.0 (net8.0+, Argh-based CLI) and updated both call sites: bare invocation needs an explicit `generate`/ `create-release` command first now, and `--label` takes a single `key=value` token instead of two. Verified against the real 0.11.0 package. Also retries `dotnet tool restore` once on failure: dotnet/sdk#53783 causes cold-cache restores of 2+ RID-specific tool packages (all of ours now are) to misattribute one package's DotnetToolSettings.xml to another. A retry always succeeds since the resolver cache is warm afterward. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Also fixed |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Procbuild-script dependency from 0.6.2 to 0.14.0 (latest) and dropsexec's manual per-argument quoting - a leftover workaround for 0.6.2's shell-based invocation. Proc 0.14+ passes args directly to the OS with no shell expansion, matchingcurb'sexec.0.14.0tagged release failing at "Build container image":-p:ContainerImageTags="edge;latest;0.14.0"came out with four quote characters instead of two, and MSBuild rejectedlatestas an unknown switch (MSB1006). Verified the fixedexecproduces a working multi-tag container push locally.release-noteswas pinned at 0.5.2, a net6.0 build - would fail the same waynupkg-validator's did ("You must install or update .NET to run this application.") on the next tagged release. Bumped the pin to 0.11.0 (net8.0+, Argh-based CLI) and fixedgeneratereleasenotes/createreleaseongithubto match its new CLI shape (explicitgenerate/create-releasecommand, single-token--label key=value). Verified against the real 0.11.0 package.dotnet tool restorenow retries once on failure: dotnet/sdk#53783 causes cold-cache restores of 2+ RID-specific tool packages (all of ours are, now) to misattribute one package'sDotnetToolSettings.xmlto another.Test plan
dotnet build build/scripts/scripts.fsproj -c Releasesucceeds../build.sh generatereleasenotes -s trueruns against the realrelease-notes0.11.0 package../build.sh publishcontainers -s truebuilds and tags the image correctly with multiple tags (edge,latest,0.14.0) - reproduced the original MSB1006 failure first with the oldexec, then confirmed the fix locally in a Linux container.0.14.1release to complete the release that failed on 0.14.0.Made with Cursor