fix(ci): full Playwright suite must not echo grep="(full)" - #1301
Merged
Conversation
JSON.stringify('(full)') inside a double-quoted bash echo closed the
quote, so `(full)` became a subshell and every shard died before tests
started. Light CI hid it because `@smoke` is not a metacharacter. This
is why develop has been red since the light/heavy split, including the
#1286 merge.
Co-authored-by: joepmeindertsma <joepmeindertsma@gmail.com>
joepio
marked this pull request as ready for review
August 21, 2026 19:24
2 tasks
joepio
added a commit
that referenced
this pull request
Aug 21, 2026
…2e] (#1302) saveOffline treated the local genesis cursor as a last-synced baseline. Reconnect POSTed genesis, then the empty follow-up export looked like "OPFS not ready" and the outbox retried forever — pendingDirtyCount stuck at 1, hasSignedGenesis false. That is the develop full-e2e failure of offline-create-then-online after #1301 unblocked the suite. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Unbreaks develop CI after #1286 (and every develop push since the Playwright light/heavy split). The product change in #1286 is not the failure.
https://github.com/ontola/atomic-server/actions/runs/32510577920
What failed
developruns Playwright full. Dagger logged the mode with:JSON.stringify('(full)')put quotes inside a double-quoted bash string, so(full)became a subshell:The suite never started. Feature-branch CI stayed green because light mode greps
@smoke, which is not a bash metacharacter.The same quoting bug has been failing develop since that split landed (including #1294 and #1295).
Fix
Log
grep=fullwithout extra quotes or parentheses.--grepis still omitted for the unfiltered suite.Checklist
bash -non the full and light shard scripts; the broken echo reproduces the CI error