ci: build atomic-saas against every push (downstream job, paired-branch rule) - #1374
Merged
Conversation
…ch rule) atomic-saas depends on ../atomic-server/lib and ../atomic-server/server by path and used to pin the commit it built against, bumping the pin in a PR of its own after every change here. Its CI now builds against develop head, so a lib rename nobody carried over would surface there days later. This job moves that failure to the push that made it: on Mancave, for non-PR events, check out ontola/atomic-saas (a branch named like this one if it exists, else main) beside this checkout and run cargo check, clippy and test against it. The Main result job fails when it fails. Pairs with ontola/atomic-saas ci/drop-server-pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with ontola/atomic-saas
ci/drop-server-pin, which drops itsATOMIC_SERVER_REFpin and builds against develop head instead.What
A
downstream-saasjob in the main pipeline, Mancave only and never on PR events: check out ontola/atomic-saas beside this checkout (a branch named like this one if it exists, elsemain), build both frontend embeds, and runcargo check,clippy -D warningsandcargo testagainst this commit. TheMainresult job fails when it fails.Uses the existing
ATOMIC_SAAS_DISPATCH_TOKENsecret for the private checkout.Why
With the pin gone, an incompatible change to
atomic_libor the server crate would otherwise surface in atomic-saas CI days later. This way it fails on the push that made it, and a coordinated change lands as two PRs on one branch name that each side's CI tests together.Testing the convention on itself
The atomic-saas branch has the same name, so this push's downstream job should report
paired branch 'ci/drop-server-pin'.