ci: downstream job also checks, lints and tests atomic-managed-node - #1375
Merged
Conversation
The first run of the pin-free pair passed here and then failed in atomic-saas's own managed-node job: the root workspace does not build atomic-managed-node, so its test still naming the removed validate_previous_commit field went unnoticed until the saas side ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1374. The first pin-free run passed the downstream job and then failed in atomic-saas's managed-node job: atomic-managed-node is not a default workspace member, so the root build never compiled its tests, which still named the
validate_previous_commitfield #1313 removed. The downstream job now runs the same clippy and test invocations the saas managed-node job does.