Skip to content

os: Implement os::Mutex - #78

Merged
MonsterDruide1 merged 1 commit into
open-ead:masterfrom
Nitr4m12:mutex
Sep 9, 2026
Merged

os: Implement os::Mutex#78
MonsterDruide1 merged 1 commit into
open-ead:masterfrom
Nitr4m12:mutex

Conversation

@Nitr4m12

@Nitr4m12 Nitr4m12 commented Sep 2, 2026

Copy link
Copy Markdown

This is mostly based on DWARF info and work I have done on nn::atk. There really doesn't seem to be more to these functions other than just calling the global Mutex functions.


This change is Reviewable

@german77 german77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nitr4m12).

@Pistonight

Copy link
Copy Markdown

I would probably also get rid of the todo comment otherwise LGTM

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Nitr4m12).


include/nn/os/os_Mutex.h line 9 at r1 (raw file):

// todo: figure out where these go
void InitializeMutex(MutexType*, bool recursive, s32 lockLevel);

Suggestion:

void InitializeMutex(MutexType*, bool recursive, s32 lockLevel);

include/nn/os/os_Mutex.h line 51 at r1 (raw file):

};

}  // namespace nn::os

add newline at end of file

Suggestion:

}  // namespace nn::os

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nitr4m12).

@MonsterDruide1
MonsterDruide1 merged commit c741e26 into open-ead:master Sep 9, 2026
2 checks passed
@Nitr4m12
Nitr4m12 deleted the mutex branch September 9, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants