Skip to content

[TEST] Code cleanup in exporter tests - #4158

Open
marcalff wants to merge 9 commits into
open-telemetry:mainfrom
marcalff:fix_test_cleanup
Open

[TEST] Code cleanup in exporter tests#4158
marcalff wants to merge 9 commits into
open-telemetry:mainfrom
marcalff:fix_test_cleanup

Conversation

@marcalff

@marcalff marcalff commented Jun 14, 2026

Copy link
Copy Markdown
Member

Fixes # (issue)

Issue

Exporter unit tests contain:

#ifndef OPENTELEMETRY_STL_VERSION

This:

  • may disable the tests in CI, depending of the setting for STL_VERSION
  • may disable include-what-you-use, likewise
  • may disable clang-tidy, likewise

Changes

Please provide a brief description of the changes here.

  • Removed the test on OPENTELEMETRY_STL_VERSION.
    • This was an old work around for an issue in GMock. The work around is no longer necessary.
  • Applied clang-format to the code
  • Resolved all issues reported by include-what-you-use

This ensures that these unit tests are always built and executed.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (a0d2d75) to head (90e8f26).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4158   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files         521      521           
  Lines       20379    20379           
=======================================
  Hits        16964    16964           
  Misses       3415     3415           
Files with missing lines Coverage Δ
exporters/otlp/src/otlp_grpc_exporter_factory.cc 50.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff
marcalff marked this pull request as ready for review July 10, 2026 20:25
@marcalff
marcalff requested a review from a team as a code owner July 10, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant