Skip to content

[CMAKE] add missing pkgconfig dependencies on instrumentation scope - #4504

Merged
dbarker merged 2 commits into
open-telemetry:mainfrom
dbarker:cmake_add_instrumentation_scope_pkgconfig_dependencies
Sep 1, 2026
Merged

[CMAKE] add missing pkgconfig dependencies on instrumentation scope#4504
dbarker merged 2 commits into
open-telemetry:mainfrom
dbarker:cmake_add_instrumentation_scope_pkgconfig_dependencies

Conversation

@dbarker

@dbarker dbarker commented Aug 31, 2026

Copy link
Copy Markdown
Member

Follow up to #4351

Changes

  • add instrumentation_scope as a pkgconfig dependency to trace, metrics, and logs.
  • update the verify script to check the instrumentation_scope pkgconfig file.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker
dbarker marked this pull request as ready for review August 31, 2026 18:05
@dbarker
dbarker requested a review from a team as a code owner August 31, 2026 18:05
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (adc5c8a) to head (c571830).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4504   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files         521      521           
  Lines       20379    20379           
=======================================
  Hits        16964    16964           
  Misses       3415     3415           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbarker
dbarker enabled auto-merge (squash) September 1, 2026 03:32
@dbarker
dbarker merged commit 1ca88d1 into open-telemetry:main Sep 1, 2026
76 checks passed
@dbarker
dbarker deleted the cmake_add_instrumentation_scope_pkgconfig_dependencies branch September 1, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants