Skip to content

[CMAKE] add missing pkgconfig dependencies on instrumentation scope #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbarker merged 2 commits into from
Sep 1, 2026
+4 −4
Merged

[CMAKE] add missing pkgconfig dependencies on instrumentation scope #4504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5b389
add missing pkgconfig dependencies on instrumentation scope
dbarker Aug 31, 2026
c571830
Merge branch 'main' into cmake_add_instrumentation_scope_pkgconfig_de…
dbarker Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/verify_packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ validate_package() {
}

# Core packages
for library in api common logs metrics resources trace version; do
for library in api common logs instrumentation_scope metrics resources trace version; do
pkg-config --validate opentelemetry_${library} --print-errors
done

Expand Down
2 changes: 1 addition & 1 deletion sdk/src/logs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ if(OTELCPP_INSTALL)
opentelemetry_add_pkgconfig(
logs "OpenTelemetry SDK - Logs"
"Components for exporting logs in the OpenTelemetry SDK."
"opentelemetry_resources")
"opentelemetry_resources" "opentelemetry_instrumentation_scope")
endif()
2 changes: 1 addition & 1 deletion sdk/src/metrics/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ if(OTELCPP_INSTALL)
opentelemetry_add_pkgconfig(
metrics "OpenTelemetry SDK - Metrics"
"Components for exporting metrics in the OpenTelemetry SDK."
"opentelemetry_resources")
"opentelemetry_resources" "opentelemetry_instrumentation_scope")
endif()
2 changes: 1 addition & 1 deletion sdk/src/trace/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ if(OTELCPP_INSTALL)
opentelemetry_add_pkgconfig(
trace "OpenTelemetry SDK - Trace"
"Components for exporting traces in the OpenTelemetry SDK."
"opentelemetry_resources")
"opentelemetry_resources" "opentelemetry_instrumentation_scope")
endif()
Loading