fix: preserve exact Windows filesystem identities - #494
Merged
Conversation
faizan-oai
marked this pull request as ready for review
August 17, 2026 20:18
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 2fc599068f95 for correctness and simplification. One optional simplification around the privacy-check call. Keep the exact bigint identity comparisons.
This is a non-blocking review. I did not run the full SDK suite or native Windows tests locally.
mldangelo-oai
previously approved these changes
Aug 17, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Rechecked 2fc5990. The earlier simplification suggestions remain non-blocking. Approving the reviewed head.
3 tasks
mldangelo-oai
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Severity: P1. Converting filesystem device and inode identifiers to JavaScript numbers can lose precision, allowing distinct Windows filesystem objects to compare equal during race checks. This keeps those identifiers exact.
Changes
Testing
pnpm run format— passed.pnpm run types— passed.pnpm run build— passed.git diff --check origin/main...HEAD— passed.Risk and rollout
Behavior changes only where an identity exceeds JavaScript's safe integer range or a replacement race occurs. The comparison remains device-plus-inode based, with no persistence or schema change.
Public disclosure review