fix: reject Windows-ambiguous portable paths - #495
Open
faizan-oai wants to merge 6 commits into
Open
Conversation
faizan-oai
changed the title
faizan-oai
force-pushed
the
agent/fix-windows-portable-paths
branch
from
August 17, 2026 20:17
5adde7a to
20a0bc8
Compare
faizan-oai
force-pushed
the
agent/fix-windows-portable-paths
branch
from
August 17, 2026 20:23
19ac119 to
5de0011
Compare
faizan-oai
marked this pull request as ready for review
August 17, 2026 20:27
mldangelo-oai
left a comment
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 5de0011508c4 for correctness and simplification. One reproduced Unix-path regression and one optional deduplication. The source-path regression was checked against both the base and this head.
This is a non-blocking review. I did not run the full SDK suite or native Windows tests locally.
3 tasks
mldangelo-oai
previously approved these changes
Aug 17, 2026
mldangelo-oai
left a comment
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Rechecked 5de0011. The Unix source-path regression still reproduces at this head. Keeping it as a non-blocking follow-up. Approving the reviewed head.
| "sarif": "exports/results.sarif", | ||
| } | ||
| WINDOWS_INVALID_PATH_CHARACTERS = frozenset('<>:"|?*') | ||
| WINDOWS_RESERVED_DEVICE_NAMES = { |
Collaborator
There was a problem hiding this comment.
Can you ask your agent to simplify this part? IMHO we should let codex handle this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Severity: P1–P2. Windows reserved names, trailing dots or spaces, alternate streams, case-insensitive collisions, and other ambiguous components can make distinct logical paths address the same filesystem object. This rejects those inputs at the relevant contract, archive, repository, output, and multiscan boundaries.
Changes
Testing
pnpm run format— passed.pnpm run types— passed.pnpm run build— passed.git diff --check origin/main...HEAD— passed.Risk and rollout
The change intentionally rejects names that are not portable or are ambiguous on Windows. POSIX colon-containing path components remain accepted outside Windows. No stored-data migration is required.
Public disclosure review