docs: inventory operator contracts - #1108
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Codex review: needs maintainer review before merge. Reviewed August 10, 2026, 5:50 PM ET / 21:50 UTC. ClawSweeper reviewWhat this changesAdds checked operator documentation for dashboard observer routes and selected configuration names, extends documentation validation, and updates contributor guidance. Merge readinessKeep this PR open for normal maintainer review. Current main does not contain its operator-documentation contract, and the current head resolves the previous executable-workflow-secret parsing blocker with focused coverage and exact-head proof. Priority: P3 Review scores
Verification
How this fits togetherThe documentation checker compares active operator references and a manifest with dashboard routing, deployment configuration, workflows, and repository instruction surfaces. It turns source/documentation drift into check failures while leaving runtime behavior unchanged. flowchart LR
A[Dashboard routes] --> D[Operator manifest]
B[Deployment and workflow settings] --> D
C[Agent and prompt docs] --> E[Documentation checker]
D --> E
E --> F[Operator reference pages]
E --> G[Documentation check result]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the source-derived operator inventory with its narrow parser boundary and keep future route or workflow-expression changes paired with manifest and fixture updates. Do we have a high-confidence way to reproduce the issue? Not applicable: this is documentation and deterministic-check work; the PR supplies an exact-head generated-site and checker run as behavior proof. Is this the best way to solve the issue? Yes. A manifest backed by source checks and focused drift fixtures is a narrow maintainable way to keep these operator references current without changing Worker behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f9a2f9493c2d. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
2c5e8ed to
3df1b25
Compare
825b847 to
5c539e6
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
5c539e6 to
f5361ed
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
f5361ed to
fe71c87
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
fe71c87 to
4a7b547
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: docs: inventory operator contracts This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Summary
What Problem This Solves
The CSW-122 audit found implemented observer routes and deployed configuration names with no current operator inventory. It also found that prompts and
.agentsinstruction surfaces were outside documentation checks, while mandatory Bay-impact and documentation-lifecycle evidence was absent from the pull-request template.Why This Change Was Made
The operator manifest ties the public route list and methods to executable Worker routing, and ties the deliberately scoped audited configuration names to Wrangler and workflow usage. The two active references state their ownership and compatibility boundaries. Checker coverage and contributor scaffolding cover the remaining source-verified governance gaps without adding unverified aliases or claiming that observer routes are versioned APIs.
User Impact
Operators can find the current observer routes and audited configuration ownership in one place. Contributors receive the existing Bay and lifecycle requirements in the PR template, and drift in these checked contracts fails
check:docs.Reconciliation
2b5b345063efe1690e1d802fb1a738aa6a408707.f9a2f9493c2d96c1ef808484924e048386284d1cafter feat(dashboard): prioritize operational telemetry #1113 merged.4a7b547136a7e047aa0fcda531de410054ad2dc8.Validation
node --test test/check-docs.test.ts test/docs-site-theme.test.ts— 33/33 passedpnpm run check:docs— passedpnpm run check:limits— passedpnpm run build:all— passedpnpm run lint— passedpnpm run check:active-surface— passedpnpm run check:dashboard-queue-boundary— passedgit diff --check origin/main...HEAD— passedoxfmt --checkover the repository's complete configured surface — 650 files passedorigin/main— no actionable defectreview --local-range --target-repo openclaw/clawsweeper --base origin/mainat the current head —keep_open, medium confidence, no GitHub mutationReview findings resolved
Accepted findings added deterministic coverage for method-aware routes, route/method pairing on one Markdown row, multiline and reordered guards, ignoring comments/templates, exact workflow-secret names, stale API table rows, multiple methods or paths in one condition, route-specific methods across Boolean branches, identical or conflicting duplicate manifest/table rows, workflow-secret extraction from executable GitHub expressions rather than inert YAML text, and method guards inherited by nested route conditions. One suggestion to require every repository workflow secret in this inventory was rejected as scope-expanding: this page intentionally covers the source-verified CSW-122 ownership gaps, while existing auth/runbook surfaces remain authoritative for other credentials.
Real Behavior Proof
Claim: The exact rebased head builds a 61-page documentation site containing both active operator references, and deterministic checks detect route/configuration/instruction drift without exposing non-current evidence as canonical.
Exercised surface: Exact pushed head
4a7b547136a7e047aa0fcda531de410054ad2dc8; production docs generator; generatedllms.txt, sitemap, public API and configuration pages; TypeScript builds; all lint lanes; active-surface/dashboard-boundary/format/docs/limits checks; focused checker/site tests.Scenario: A clean GitHub clone of the pushed branch was built in Docker-backed Crabbox. The proof asserted both new active pages are in canonical discovery, representative route/configuration names render, all focused positive/negative tests pass, and the repository-wide deterministic surfaces are clean.
Command/environment: Crabbox
0.40.0, requiredprovider=local-container, imagenode:24-bookworm,--fresh-pr openclaw/clawsweeper#1108 --no-hydrate; the harness cloned and asserted the exact pushed branch. Docker Server29.5.2.Observed result:
CSW122_PR2_HEAD=4a7b547136a7e047aa0fcda531de410054ad2dc8, 33/33 tests passed, 650-file format check passed,Documentation checks passed,CSW122_PR2_PROOF=PASS, exit 0.Artifact/trace: Lease
cbx_885ca7f11dfc(harbor-barnacle), providerlocal-container, imagenode:24-bookworm,runStatus=succeeded, command 25.218s, total 38.394s, lease stopped. Local harness:C:\clawsweeper-work\notes\csw-122-pr2-proof.sh.Limits: This proves exact-head generation and deterministic contract checks in Linux. It does not deploy, probe authenticated or internal routes, validate secret values, or promise compatibility for diagnostic response schemas.
OpenClaw Bay Impact
No Bay runtime, data contract, artwork, or controls change. This PR documents existing observer projections and adds the existing Bay-impact requirement to contributor scaffolding.
Documentation Lifecycle
docs/public-api.mdanddocs/operator-configuration.mdare active operator references with role owner, source, verified revision, update triggers, and checker. No proposed or historical page changes lifecycle.Risks and Rollback
Non-goals
AGENTS.mdexplicitly documents the current strategy.Stack / Order
PR 1, #1107, is merged. This PR is now directly based on current
mainand contains only the intended CSW-122 second-layer operator/governance diff.Related