feat(dashboard): prioritize operational telemetry - #1113
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Codex review: needs maintainer review before merge. Reviewed August 10, 2026, 5:24 PM ET / 21:24 UTC. ClawSweeper reviewWhat this changesThe PR puts operational telemetry before repository coverage on the dashboard overview and collapses the coverage inventory behind a native disclosure. Merge readinessKeep open for a maintainer product decision: the patch is technically sound and proof-backed, but it intentionally makes per-repository coverage less immediately discoverable. Priority: P2 Review scores
Verification
How this fits togetherThe dashboard Worker combines review coverage and operational-health data into an operator overview. This change only changes the order and default visibility of those existing rendered sections. flowchart LR
A[Review coverage data] --> B[Dashboard Worker]
C[Operational health data] --> B
B --> D[Health hero]
B --> E[System overview]
B --> F[Coverage disclosure]
D --> G[Operator decision making]
E --> G
F --> G
Decision needed
Why: The patch preserves aggregate degraded coverage, but the appropriate default discoverability of detailed per-repository flags is an operator-UX decision rather than a correctness fact. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Adopt the native disclosure only if maintainers explicitly accept telemetry-first scanning over always-visible per-repository detail, then refresh the branch and browser proof if #1112 lands first. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: the PR body provides a concrete exact-head Chromium scenario showing the intended desktop, narrow-screen, disclosure, keyboard, and degraded-health behavior. Is this the best way to solve the issue? Yes, conditionally: native details is the narrowest maintainable implementation, but maintainers must decide whether the default discoverability tradeoff is acceptable. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 91272a65e6ff. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles)
|
clawsweeper
Bot
added
merge-risk: 🚨 other
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
clawsweeper
Bot
added
rating: 🐚 platinum hermit
d67585b to
6f3571a
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
1 participant
Summary
Problem
The overview opened with a long repository inventory. On production-sized data that inventory consumed the initial viewport and pushed queue, throughput, capacity, and incident telemetry far below the fold. Operators had to scroll past coverage detail before they could answer the page's primary questions: whether the system is healthy, whether work is flowing, and where intervention is needed.
Implementation
System Overviewand its operational cards precede repository coverage in document order.<details>/<summary>, collapsed by default.Validation
Exact head:
6f3571adf1fe028483f94e934db067419286f66dTree:
7b1150e2ecbd5994be97da99984e95792df44263Recorded base:
91272a65e6ffbf1eafddf520639c9acbd339e1bfUser-authorized direct local Docker proof used pinned image:
mcr.microsoft.com/playwright@sha256:9bd26ad900bb5e0f4dee75839e957a89ae89c2b7ab1e76050e559790e946b948The container materialized the exact commit with
git archivefrom read-only Git objects, asserted commit/tree/manifest identity, then ran:Results:
git diff --checkpassed and the host worktree remained clean at the exact head.Real Behavior Proof
Claim: the dashboard's initial desktop viewport prioritizes operational health and telemetry while keeping complete repository exploration reachable and accessible.
Exercised surface: the exact archived Worker/dashboard build was served with Wrangler inside the pinned Linux container and exercised with real Chromium/Playwright.
Scenario/fixture: deterministic healthy/degraded operational data plus two repository coverage fixtures, including per-repository flags and explicit loading and error responses.
Observed result:
System Overviewbegan at y=422.56 (above fold); repository coverage began at y=2849.91 and followed it in heading/document order.7d coverage 50% · 3 stalewhile the inventory was collapsed.Artifacts retained outside the worktree under
C:\clawsweeper-work\artifacts\csw-125\direct-docker-6f3571adf1include the browser report, test transcripts, archive/manifest hashes, exit code, and screenshots. Containercsw-125-direct-proof-6f3571adf1(ec6244f6616e954aa3e1b61ce354f9198caf723ffa57ce67918bc2151172fe26) ran from2026-08-10T21:15:14Zto21:16:04Zand exited 0:overview-desktop-1440x900.pngoverview-narrow-390x844.pngrepository-coverage-open.pngrepository-coverage-narrow-open.pngrepository-coverage-summary-focus.pngThe successful proof container exited 0 and was removed by its exact task-owned name after its ID, inspection, log, and Docker events were recorded. Other task containers were not modified.
Proof boundary: this is Martin-authorized direct-Docker evidence, not a Crabbox lease/run receipt. Earlier Crabbox local-container/AWS transport failures are retained as infrastructure diagnostics; they did not weaken or replace this unchanged exact-head proof contract. No production mutation or deployment was performed.
Review closeout
<summary>. The heading was moved immediately before<details>, the toggle was made phrasing-only, and structural tests were updated.keep_openwith high confidence.Accessibility and responsive checks
<details>/<summary>provides keyboard and assistive-technology disclosure semantics.:focus-visibletreatment and retains focus when toggled.Compatibility and overlap
91272a65e6ffbf1eafddf520639c9acbd339e1bfand is the exact proof base.git range-diffconfirmed this PR's two commits replayed unchanged above its branch-authority, Worker, and test changes.Risks and rollback
Risk is limited to overview presentation and discoverability: operators accustomed to the expanded inventory need one disclosure action. Counts and degraded status remain visible before expansion, and native disclosure behavior avoids custom state machinery. Rollback is a single-commit revert; no data, API, polling, queue, runtime, route, or deployment migration is involved.
Non-goals